#45 Preserve filename when switching branches in general search

David Faure

The links to other branches ("variables") from the "search" page only preserve the _string, but not the _filestring.
For the convenience of users, better provide both. Fixed in the attached patch.

The fix can be tested live at


  • David Faure

    David Faure - 2014-04-05

    The patch

  • Andre-Littoz

    Andre-Littoz - 2014-04-06
    • assigned_to: Andre-Littoz
  • Andre-Littoz

    Andre-Littoz - 2014-04-06

    Hi David,

    You're right. Since I try to preserve user entry, I should have also preserved _filestring. But thinking carefully about it, your suggestion is not complete. The goal is to preserve user transaction. It is defined by 4 parameters: the two strings you mentioned and the state of the 2 checkboxes.

    Consequently, I added also _casesensitive and _advanced. I consider this a bug on me!

    I take the oportunity to ask a question. I had a look at the KDE site. It sends XML or XHTML. Have you encountered difficulties with LXR emitting HTML? For instance, "break to next line" is <BR> not <BR />. There may be other instances, though I tried all my best to balance opening tags with closing tags, even if they are optional in the HTML standards.

    A remark: you customized the look-and-feel so that it is consistent with the rest of the KDE sites (KDEcolors = kde.css style sheet), but you didn't forward or redefine the source-styling definitions. Consequently, there is no highlighting of keywords, variable or function names, ... The only decoration left is the default <A> highlighting when you hover your mouse over an item. Don't you think you lose some usefulness with the lack of visual cues?

    A request: I'd be very proud if you could add some mention about LXR (for instance, near the copyright notice for KDE and its logo). This would publicly advertise the app and be a kind reward for the time I spend on LXR. Thanks in advance.

  • Andre-Littoz

    Andre-Littoz - 2014-06-03

    Fixed in release 2.0.2

  • Andre-Littoz

    Andre-Littoz - 2014-06-03
    • status: open --> closed-fixed

Log in to post a comment.