[Alexander Schuettelkopf <A.Schuettelkopf@du...>]

Hi,

I am trying to get some Fortran support into LXR (like so many others, 
seemingly), but due to some surprising and annoying properties of the 
language (I'm not a Fortran programmer myself) it is 
inefficient/hard/impossible to do with LXR::Lang::Generic. So I thought 
I'd just derive a new Lang class and write my own parser, but one of the 
routines I most definitely need to override is &LXR::SimpleParse::nextfrag.
Now I could either write some really ugly code with lots of "if (... eq 
'Fortran')" _or_ duplicate the whole generic.conf mechanism for 
SimpleParse or move all of SimpleParse into Lang::Generic (which I would 
prefer). My question is: is there any good reason why the SimpleParse 
routines are in a module of their own. Given their dependency on data 
from generic.conf etc I would have thought it most sensible to move them 
into Lang::Generic as two additional methods. If a derived class wants 
to use the Generic mechanisms it automatically has the parser routines 
that go with it, whereas if it doesn't it can simply overload them...
Does this make any sense? Of course I had also hoped that, once I got my 
Fortran parser working, I could submit it, so I'd prefer to be as 
compatible with the _real_ LXR as possible.

On a completely different note, there is a problem in 
&LXR::Files::Plain::tmpfile - the routine doesn't check whether a file 
with the temporary name already exists. While in general that should not 
be a problem, it turns out to be quite disastrous for doing diffs on 
small- to medium-sized files, as they have a good chance to be tmpfile'd 
in the same second. The result is that no matter what you choose in the 
UI, you always end up with the second file being compared to itself. A 
cheap fix would be something like:

sub tmpfile {
        my ($self, $filename, $release) = @_;
        my ($tmp,$tries)=('/tmp/lxrtmp.'.time.'.'.$$.'.',0);
        local ($/) = undef;

        while (-e $tmp.$tries) { $tries++; }
        $tmp.=$tries;

        open(TMP, "> $tmp") || return undef;
...
...

Do I have to respectively am I allowed to file a bug report for this? I apologise if this should have gone to the -dev list. Is that one open for uninvited posting?

Cheers,
Alexander Schuettelkopf