#244 LXR at site-root not recognised

current_cvs
closed-fixed
None
7
2013-11-20
2013-08-20
No

Regression in current_cvs against 1.2.0

When LXR is the only service in site (URL of the form http://localhost/source), virtual root is reduced to /. To identify a tree (even in the single-tree case), a comparison is made on the host name and the virtual root.

But, the virtual root is later used to create a <base> tag in the HTML header of every page to avoid full URL in the links. The base URL is usually the virtual root (without trailing slash) which is prefixed on the relative links. However, the shortest virtual host / cannot be used, lest all relative links are erroneously transformed into absolute links (no longer pointing into the LXR section), and is simply erased. This erasure prevents positive recognition of / in the configuration file.

Suggested fix: move the erasure after tree identification

Note: to be honest, when LXR is at the root-site, there is no difference between relative and absolute HTML paths. But, if the virtual root is left as is, links will contain // at their beginning instead of /. Browsers may ignore this bad path, but there is no certainty about the immune effect of this writing.

Discussion

  • Andre-Littoz

    Andre-Littoz - 2013-08-21

    See also bug #245

    Suggested fix does not solve the bug. We need absolute HTML paths (relative to the current host). // in the initial position points to another (usually non-existent) site.

     
  • Andre-Littoz

    Andre-Littoz - 2013-08-25
    • Description has changed:

    Diff:

    --- old
    +++ new
    @@ -1,4 +1,4 @@
    -Affects 1.1.0 and 1.2.0
    +Regression in current_cvs against 1.2.0
    
     When LXR is the only service in site (URL of the form http://localhost/source), virtual root is reduced to /. To identify a tree (even in the single-tree case), a comparison is made on the host name and the virtual root.
    
     
  • Andre-Littoz

    Andre-Littoz - 2013-11-20

    See fix for bug #245

     
  • Andre-Littoz

    Andre-Littoz - 2013-11-20
    • status: open --> closed-fixed
     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:

JavaScript is required for this form.





No, thanks