Regression in current_cvs against 1.2.0
When LXR is the only service in site (URL of the form http://localhost/source), virtual root is reduced to /. To identify a tree (even in the single-tree case), a comparison is made on the host name and the virtual root.
But, the virtual root is later used to create a <base> tag in the HTML header of every page to avoid full URL in the links. The base URL is usually the virtual root (without trailing slash) which is prefixed on the relative links. However, the shortest virtual host / cannot be used, lest all relative links are erroneously transformed into absolute links (no longer pointing into the LXR section), and is simply erased. This erasure prevents positive recognition of / in the configuration file.
Suggested fix: move the erasure after tree identification
Note: to be honest, when LXR is at the root-site, there is no difference between relative and absolute HTML paths. But, if the virtual root is left as is, links will contain // at their beginning instead of /. Browsers may ignore this bad path, but there is no certainty about the immune effect of this writing.
Log in to post a comment.