#217 Identifier query faulty with CVS tree

current_cvs
closed-fixed
Browsing (93)
6
2012-09-08
2012-08-26
No

With a source-tree under CVS, identifier search may return no result or erroneous results even if the looked-for identifier exists. This happens when the set of versions is defined by a function. This function returns the correct set when LXR is processing a file (under source) but only "head" in all other cases (directory under source, or ident).

This is caused by the security check "clean_release" in Common.pm which filters the requested version against those in {'v'}{'range'}. In the mentioned cases, {'range'} is empty and default 'head' is returned.

It really matters only for ident since it is always possible to change default version (from directory) once we hit a file.

Suggested fix:
in clean_release, test if repository is CVS and script is source; if yes, accept any version.

Discussion

  • Andre-Littoz

    Andre-Littoz - 2012-09-08
    • status: open --> closed-fixed
     
  • Andre-Littoz

    Andre-Littoz - 2012-09-08

    Fixed in 1.0 release.
    Patch also improved to keep version selection through directory listing.

     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks