#204 diff in 'many variables' context: incorrect versions

Browsing (93)

If a diff markup is requested in a context where many variables can be selected (e.g. kernel browsing with architectures and sub-architectures enabled), the "version" selection step does not hand over the correct variable name/value to diff.

The final name/value retained may well be totally irrevelant to the architecture under scrutiny.

As a side-improvement, use the 'when' attributes to limit the number of proposed choices (in the message, since only the "active" variables are displayed in the header).


  • Andre-Littoz

    Andre-Littoz - 2012-03-27
    • status: open --> closed-fixed
  • Andre-Littoz

    Andre-Littoz - 2012-03-27

    Fix to this bug involved a redesign of the way the request is submitted to diff. Formely, two argument variables were used: _diffvar contained the name of the variable to compare to and _diffval the value.

    To be able to handle an indefinite number of variables, the full reference set of values is passed as argument ~xx=value where xx is the name of the variable. The target set is defined through xx=value (link insterface which can provide only one variable) or !xx=value (buttons-and-menus interface where any number of variables can be clicked).

    As a side-effect, argument variables _file and _dir are no longer used since the reference set ~xx and new sub unmappath allow to reverse the effects of 'maps' before reapplying the rules with the new set xx and/or !xx.

    The new cleaner design removed the need for $incargs{} marker in the templates since everything needed is already in urlargs{}.


Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:

No, thanks