#4 patch to turn desktop switching buttons into a real pager

[Myles Green]

the attached patch will, when applied to icewm-1.2.30, turn the plain desktop switching buttons into a mini-pager. It will show mini 'windows' inside the buttons. If the application is large enough the mini widows will show the application's icon inside it. The desktop numbers can be turned on or off. Here are the configurable switches:

PagerShowPreview=1 # 0/1
PagerShowMinimized=0 # 0/1
PagerShowBorders=1 # 0/1
PagerShowNumbers=0 # 0/1

The patch was created by Thomas Holder an we have his blessing to go ahead and use it. Yes, I know the patch is GPL'd but I asked for permission anyway and got his approval.

[Myles Green]

patch to modify desktop switching buttons

[Manuel Carrasco]

Logged In: YES
user_id=1194907
Originator: NO

The patch has been applied with little modifications to cvs version, please test it.

Thanks, Manolo

[Myles Green]

Logged In: YES
user_id=122802
Originator: YES

Hi Manolo, sorry for my late response to your request. I've only just gotten back on my feet after having spent the last 2 weeks laying flat on my back because of runaway pain.

I've checked out lxp-icewm-1.2.30 from cvs (11:56 UTC 30-03-2007) and building/installing with

./configure --prefix=/usr --enable-gradients --enable-antialiasing -enable-lookxp --enable-menu-leftpixmap --enable-taskbutton-over

The build was successful (no errors and just 1 or 2 warnings) as was the install, however lxp-icewm refuses to start. I renamed ~/.lxp-icewm and tried again but it still will not start up. I see no error messages being logged and I end up being log'd into the non-lxp version of IceWM which I also have installed. I'm thinking I need to uninstall that version (icewm-1.2.30) and re-install lxp-icewm-1.2.30, is this correct or could it be something else?
Thanks, Myles

[Manuel Carrasco]

Logged In: YES
user_id=1194907
Originator: NO

Hello Myles,

1.- You have to provide me with more information about the crash, I think the problem is in an applet. Try exec lxp-icewm disabling different applets and isolate the problematic one. You can play with these are the parameters in the preferences file.
TaskBarShowCPUStatus=1
TaskBarShowNetStatus=1
NetworkStatusDevice="eth0 eth1 ppp0"
TaskBarShowMixer=1
TaskBarShowAPMStatus=1
TaskBarShowAPMTime=1
taskBarShowDSKStatus=1

TaskBarShowWorkspaces=1
PagerShowPreview=1
PagerShowNumbers=0

2.- Makefile in cvs was wrong and did not install all themes, I've fixed it.

Regards, Manolo

[Myles Green]

Logged In: YES
user_id=122802
Originator: YES

I think the reason lxp was crashing was because my installation was corrupted/broken. Since I re-installed lxp - using the lxp-setup script - everything is fine. In a post you made to the forums in answer to a question posted by Christian you said the following needed to be added to ./configure ::

--enable-mnuleftpixm
--enable-btnoverpixm

but when I looked at the options via "./configure --help|less" I found this:

--enable-menu-leftpixmap
--enable-taskbutton-over

which I used during my last build. I just updated via CVS and re-built and this time I put both versions down as options to ./configure. The whole thing looked like this:

$ ./configure --prefix=/usr \ > --exec-prefix=/usr \ > --datadir=/usr/share \ > --sysconfdir=/etc \ > --with-docdir=/usr/share/doc \ > --enable-lookxp \ > --enable-menu-leftpixmap \ > --enable-mnuleftpixm \ > --enable-taskbutton-over \ > --enable-btnoverpixm \ > --enable-gradients \ > --enable-guievents \ > --with-icesound=OSS,ALSA \ > --enable-xfreetype \ > --enable-i18n \ > && make \ > && su -c "make install"

The configure went through with no errors but make failed when it got to the point where it was trying to compile icesound. Here is the error message:

<cut>
LD lxp-icewm-session
CXX icesh.o
LD lxp-icesh
CXX icewmhint.o
guievent.h:33: warning: ‘gui_events’ defined but not used
LD lxp-icewmhint
CXX icewmbg.o
LD lxp-icewmbg
CXX icetray.o
LD lxp-icewmtray
CXX icesound.o
icesound.cc:193:21: error: sndfile.h: No such file or directory
icesound.cc:133: warning: ‘class YAudioInterface’ has virtual functions but non-virtual destructor
icesound.cc:195: warning: ‘class YALSAAudio’ has virtual functions but non-virtual destructor
icesound.cc: In member function ‘virtual void YALSAAudio::play(int)’:
icesound.cc:267: error: ‘SF_INFO’ was not declared in this scope
icesound.cc:267: error: expected `;' before ‘sfinfo’
icesound.cc:268: error: ‘SNDFILE’ was not declared in this scope
icesound.cc:268: error: ‘sf’ was not declared in this scope
icesound.cc:268: error: ‘SFM_READ’ was not declared in this scope
icesound.cc:268: error: ‘sfinfo’ was not declared in this scope
icesound.cc:268: error: ‘sf_open’ was not declared in this scope
icesound.cc:270: error: ‘sf_strerror’ was not declared in this scope
icesound.cc:332: error: ‘sf_readf_short’ was not declared in this scope
icesound.cc:339: error: ‘sf_close’ was not declared in this scope
icesound.cc: At global scope:
icesound.cc:363: warning: ‘class YOSSAudio’ has virtual functions but non-virtual destructor
icesound.cc: In static member function ‘static void IceSound::printUsage()’:
icesound.cc:1012: warning: too many arguments for format
make[1]: *** [icesound.o] Error 1
make[1]: Leaving directory `/home/myles/tmp/lxp-icewm-1.2.30/src'
make: *** [base] Error 2
</cut>

I didn't bother to take the time to figure out why it wouldn't build, I just removed "--enable-guievents and --with-icesound=OSS,ALSA" after a "make clean" and the build was successful. This time around I noticed that ALL the themes were installed, last time only 2 themes got installed. Thanks for fixing that and also thanks for including this patch. I should note here that I do miss the ability to turn off the display of the window frames of minimized applications (in the pager, it was part of the original patch) but I guess I can learn to live without it.