Thank you. Patch looks fine except you used gtk_menu_item_new() for menu items and that will create menu lines with empty labels. If you wish to drop stock image menu class then you should add a label with mnemonics and a stock image to the menu item. Read https://developer.gnome.org/gtk3/stable/GtkImageMenuItem.html for details, please.
Last edit: Lonely Stranger 2020-04-01
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Please, attach patch in unified format. Yours cannot be applied. Thank you.
Here is the one created with git format-patch. Hope this works.
Thank you. Patch looks fine except you used
gtk_menu_item_new()for menu items and that will create menu lines with empty labels. If you wish to drop stock image menu class then you should add a label with mnemonics and a stock image to the menu item. Read https://developer.gnome.org/gtk3/stable/GtkImageMenuItem.html for details, please.Last edit: Lonely Stranger 2020-04-01
And what do you think about using glade for gtk 3.2 + version?
Negative. It will break GTK+2 build. I'm sorry.
I used example from gtk docs and fixed issues you metioned. This patch should be applied after first one.
You missed GTK_STOCK_PREFERENCES in your changes. Thank you.
What do you mean? I found no usage of GTK_STOCK_PREFERENCES in code for gtk3.10 and above. But for older versions it was preserved.
I mean - with your changes there will be no
Preferencesitem in the menu.Oh, yes, sorry. Fixed.