Menu

#537 [lxpanel] alsavolume plugin fails to build without ALSA

-
closed-accepted
lxpanel (21)
9
2016-11-21
2016-11-19
No

lxpanel 0.9.0 does not build when ALSA is disabled (manually on Linux, because of lack of ALSA on non-Linux platforms).

The issue is that in the volumealsa_configure function (in plugins/volumealsa/volumealsa.c), the "j" variable is also used outside the !DISABLE_ALSA blocks (so used in all the cases), while its declaration is inside one ( declared only when ALSA is available).

The easy fix is to move the declaration.

1 Attachments

Discussion

  • Lonely Stranger

    Lonely Stranger - 2016-11-20
    • labels: --> lxpanel
    • assigned_to: Lonely Stranger
    • Priority: 5 --> 9
     
  • Lonely Stranger

    Lonely Stranger - 2016-11-20

    Thank you very much for such fast notice. Will release fixed update pretty soon then. :)
    I would like to also ask if you happen to know good mixer for !Linux, as those listed in the plugin seem to be either pulse, or alsa, so linux-only. Do you know any other one available on !Linux platform, either GUI or console, so I could add it to the list to find?

     
  • Pino Toscano

    Pino Toscano - 2016-11-20

    libpulse should generally be an OS-independent API, and it has backends for ALSA, OSS, etc -- so that should be usable in non-Linux UNIX platforms.

     
  • Lonely Stranger

    Lonely Stranger - 2016-11-21
    • status: open --> closed-accepted
     
  • Lonely Stranger

    Lonely Stranger - 2016-11-21

    Well, for OSS build alsa mixers checks are disabled now but aumix and xfce4-mixer checks added. Thank you.

     

Log in to post a comment.

MongoDB Logo MongoDB