#504 [lxsession] stop pretending to use dbus-glib

[galtgendo]

...cause for most part vala generates gdbus code anyway.

About the only part that still uses dbus-glib - and pretty much incorrectly at that - is lxsesion/dbus-common.vala via DBus.Error. I'm just about certain the current code is wrong there, as gdbus won't return DBus.Error. Though there might be a better, more narrow category than generic Error.

The attached patch covers bit more.

1. '-D USE_GTK2' and '-D USE_GTK3' aren't being passed correctly to the vala sources.
2. In gtk3 there's Gtk.Application, so Application is ambiguous - I assume GLib.Application was meant; though given some messages, I strongly suspect the original code is somehow broken/incomplete
3. drawing code in lxsession-logout/lxsession-logout.c isn't properly ported to gtk3; though that code might need less trivial port as while the pixbuf is now drawn and buttons look correct too, the widget surrounding the buttons is just gone
4. the final and most painful problem (lxsession/app.vala and lxsesion/main.vala, thought the second one likely redundant) - old config file don't work, that is window manager fails to be run without this hack; for some reason, global_settings.get_item_string("Session", "window_manager", null) seems to be returning null, even though 'window_manager=openbox' is present in 'Session' section of the config file;

[galtgendo]

oops...

wrt. to 4.: to clarify, this happened during upgrade from lxsession-0.4.9.2 to 0.5.2

[galtgendo]

..so, I see that some portions of this problem are being solved by separate patches (like (for example) problem 2 in patch [#511])

On the other hand (damn, I can't get over of how retarded this web interface is - ...it's only semi-random), that fourth problem seems to be solved by a Fedora patch (key2-null - see their repo).

Yet, I can't find any other open issues adressing the central problem - the non-use of dbus-glib.

[galtgendo]

...that was meant to say "like (for example) problem 3 in patch [#511]" , problem 2 is patch [#526].

[gilir]

Thanks for your patches. I pushed several changes to git today, including the fedora patch. Let me know if it's covering all the changes you had in your original patch.