#336 xkb plugin: per-window layout

closed-fixed
martyj19
None
5
2010-05-11
2010-05-04
Erez Volk
No

First of all, thank you for a great product!

Below is a suggested patch that enhances the "layout per application" functionality: instead of a boolean "per application setting" I have implemented a three-way selection: "Global" vs. "Per Application" vs. "Per Window".

When I work, I often have two Firefox windows, each with a different layout. This setting allows me to work this way.

What do you think?

Discussion

  • martyj19

    martyj19 - 2010-05-04

    Thank you for your contribution. This looks like a good improvement. It may take me a few days to get to it, go through and see what it does.

     
  • martyj19

    martyj19 - 2010-05-11

    After further review, I conclude that the current behavior is a bug. The layout should switch based on toplevel window rather than process ID of the controlling process. It is an implementation artifact whether or not a given application window is controlled by a separate process. So, the correct behavior is your proposed new behavior.

    Checked in as git commit a6ef237eda5ef74e31b9cf8f1ec1c6607d71f64e.

     
  • martyj19

    martyj19 - 2010-05-11
    • assigned_to: nobody --> martyj19
    • status: open --> closed-fixed
     

Log in to post a comment.