From: Piotr S. <pio...@gm...> - 2015-07-13 11:36:55
|
Hey Andriy, 13 lip 2015 06:39 "Andrej N. Gritsenko" <an...@re...> napisał(a): > The commit where many different changes are all-in-one is > very hard to be understood, to review ang get commented, and your biggest > commit has at least 5 things in it: a) indentations changes; b) many data > members renamed; c) bugs fixed; d) forecast feature improvement; e) fix > for hang due to data retrieval in main thread. So in short, I have no big > idea what to comment on it so I think it should be just merged with the > master after we done with 0.8.x and will prepare 0.9.0. I hope you would > take this into consideration on your further work and would split your > further commits into few more atomic ones (i.e. with one kind of change > in each) so they can be reviewed and commented. Of course. That makes complete sense and I will keep that in mind for my future work. Thanks. > With best regards, > Andriy. Best wishes, Piotr |