From: Piotr S. <pio...@gm...> - 2015-07-12 02:47:08
|
On 08/01/2014 08:33 PM, Andrej N. Gritsenko wrote: > Hello! Hi Andriy, All, > No updates from you, though I found some updates in your repository. It's been a while and I've made some more updates, details follow: > 1) the function gtk_weather_button_pressed() will be never called for > button 3 since the panel will catch and handle it, therefore the item > 'Refresh' should be added in callback .update_context_menu() instead of > creating unused popup menu. Yup. I don't consider it critical, but I understand the 'need' for it. Added it to the issue tracker [1]. > 2) gtk_weather_preferences_dialog_response() should never destroy the > preferences dialog because panel handles that thing. > 3) gtk_weather_create_preferences_dialog() should always create new > preferences dialog due to (2) and never use the same one again. I think you've taken care of these two on upstream/master, I've rebased on your changes and sprinkled some of my own magic there -- thanks. > 4) might it be better to use conditional compilation instead of using > conditional execution? That way we can omit some unused code when it's > used as panel plugin. It looks like that's what you did on master. I completely removed the app-specific code from the plugin -- it was just taking up space. The proper way of reusing code would have been for me to generate a shared library and go from there. Thanks for cleaning it up. I've also fixed: - the threading issue brought up by Henry Gebhardt 2 1/2 (!!!) years ago (essentially with a slow network, the weather plugin would slow down lxpanel's startup) [2] - the forecast for 'Tomorrow' was actually the forecast for 4 days from 'Today', due to a parsing bug [3] (the fix also effectively adds a requested feature [4]). All of the above fixes to the plugin are available for a 'pull' from the '1-threading' branch of my fork of the lxpanel repo [5] The standalone app got the same updates and can be cloned directly from its repo [6]. Review comments, questions, bug reports and feature requests are always welcome (and can be submitted directly via the app issue page [7]). Cheers! Piotr [1]: https://github.com/psipika/lxpanel/issues/2 [2]: https://github.com/psipika/lxweather/issues/5 [3]: https://github.com/psipika/lxweather/issues/2 [4]: https://github.com/psipika/lxweather/issues/1 [5]: https://github.com/psipika/lxpanel/tree/1-threading [6]: https://github.com/psipika/lxweather [7]: https://github.com/psipika/lxweather/issues |