From: Piotr S. <pio...@gm...> - 2014-08-04 17:44:12
|
On 08/01/2014 08:33 PM, Andrej N. Gritsenko wrote: > Hello! Hi! > No updates from you, though I found some updates in your repository. Yup, I try to work on the plugin when I have some time, but I don't want to spam the list with updates for incomplete functionality... > Few notes on it: > > 1) the function gtk_weather_button_pressed() will be never called for > button 3 since the panel will catch and handle it, therefore the item > 'Refresh' should be added in callback .update_context_menu() instead of > creating unused popup menu. > 2) gtk_weather_preferences_dialog_response() should never destroy the > preferences dialog because panel handles that thing. > 3) gtk_weather_create_preferences_dialog() should always create new > preferences dialog due to (2) and never use the same one again. > 4) might it be better to use conditional compilation instead of using > conditional execution? That way we can omit some unused code when it's > used as panel plugin. Thanks for these suggestions. I'll put those in as soon as I can. > With best regards, > Andriy. Cheers! Piotr |
From: Piotr S. <pio...@gm...> - 2014-07-06 23:06:06
|
On 07/05/2014 06:05 AM, Andrej N. Gritsenko wrote: > Hello! Hi Andriy! >> I don't want to hold back the release, so my plan is to do the following >> by the end of this weekend: >> 1) fix configuration persistence Still working on this. Turns out that with the migration to the new plugin API, I'll have to clean up the plugin internals a bit more than I'd anticipated. The 'good' news is that these two problems: >> 2) fix the 'refresh' logic in the details screen >> 3) [possibly] move initial forecast retrieval from main thread will be addressed at the same time as #1, above. I'll put in some time here and there, and will provide status, hopefully on a weekly basis. Warmest wishes! Piotr |
From: Andrej N. G. <an...@re...> - 2014-07-07 10:34:36
|
Hello Piotr! Piotr Sipika has written on Sunday, 6 July, at 19:05: >I'll put in some time here and there, and will provide status, hopefully >on a weekly basis. That's great! Thank you very much! >Warmest wishes! >Piotr With best wishes, Andriy. |
From: Piotr S. <pio...@gm...> - 2014-03-31 01:28:09
|
On 03/25/2014 10:05 PM, Andrej N. Gritsenko wrote: > Hello! Hey Andriy. > How does the progress going on that? I took a bit of time this week and had a look as to what still needs to be done. I've started on cleanup and minor usability updates and will continue to make those changes as I go through the debugger/valgrind. Here's what I'll be working on (slowly), in the order of priority: 1) Migrate to the new plugin API (in progress). 2) Move initial forecast retrieval from the main thread so that the panel is not bogged-down by the plugin. 3) Finalize cleanup/usability updates. 4) Migrate threading to GThread (this is last because I'll probably end up streamlining the logic a bit more) I can't guarantee anything, but your efforts are definitely a motivating factor. Once again, thank you to all for some wonderful feedback and I look forward to the next 'iteration.' > Cheers, > Andriy. Warmest thanks and best wishes! Piotr |
From: gary s. <rh...@gm...> - 2014-03-31 01:59:27
|
Looking forward to this! On Sun, Mar 30, 2014 at 6:27 PM, Piotr Sipika <pio...@gm...>wrote: > On 03/25/2014 10:05 PM, Andrej N. Gritsenko wrote: > > Hello! > Hey Andriy. > > > How does the progress going on that? > I took a bit of time this week and had a look as to what still needs to > be done. > > I've started on cleanup and minor usability updates and will continue to > make those changes as I go through the debugger/valgrind. > > Here's what I'll be working on (slowly), in the order of priority: > > 1) Migrate to the new plugin API (in progress). > 2) Move initial forecast retrieval from the main thread so that the > panel is not bogged-down by the plugin. > 3) Finalize cleanup/usability updates. > 4) Migrate threading to GThread (this is last because I'll probably end > up streamlining the logic a bit more) > > I can't guarantee anything, but your efforts are definitely a motivating > factor. > > Once again, thank you to all for some wonderful feedback and I look > forward to the next 'iteration.' > > > Cheers, > > Andriy. > Warmest thanks and best wishes! > > Piotr > > > > > ------------------------------------------------------------------------------ > _______________________________________________ > Lxde-list mailing list > Lxd...@li... > https://lists.sourceforge.net/lists/listinfo/lxde-list > |
From: Andrej N. G. <an...@re...> - 2014-03-31 10:08:52
|
Hello! Piotr Sipika has written on Sunday, 30 March, at 21:27: >I took a bit of time this week and had a look as to what still needs to >be done. Great news! Thank you very much! >I've started on cleanup and minor usability updates and will continue to >make those changes as I go through the debugger/valgrind. Just to note if you don't noticed yet. The sourceforge GIT is not in use anymore, so add git.lxde.org and set it as defaut remote for all your branches, please. Ask PCMan if you don't have access to git.lxde.org repo yet. >Here's what I'll be working on (slowly), in the order of priority: >1) Migrate to the new plugin API (in progress). As I said already - feel free to ask if you have any questions. 4 out of external plugins are migrated already so you have examples. >2) Move initial forecast retrieval from the main thread so that the >panel is not bogged-down by the plugin. >3) Finalize cleanup/usability updates. >4) Migrate threading to GThread (this is last because I'll probably end >up streamlining the logic a bit more) >I can't guarantee anything, but your efforts are definitely a motivating >factor. >Once again, thank you to all for some wonderful feedback and I look >forward to the next 'iteration.' >Warmest thanks and best wishes! >Piotr With best regards. Andriy. |
From: Piotr S. <pio...@gm...> - 2014-07-05 00:43:47
|
On 07/03/2014 04:22 PM, Andrej N. Gritsenko wrote: > Hello! Hey Andriy! > What is the current state of this work? I believe it is the time to > make a release for LXPanel so we need some progress into this plugin as > well. I'm 95% done migrating the plugin to the new API. The only thing missing is saving configuration to the panel config file -- I need to look over other plugins' source to figure out how and when their configuration gets written to the file (would appreciate some help with that - a point in the right direction - if you have a bit of time). I don't want to hold back the release, so my plan is to do the following by the end of this weekend: 1) fix configuration persistence 2) fix the 'refresh' logic in the details screen 3) [possibly] move initial forecast retrieval from main thread I just pushed some changes to github[1]. If you have any other comments, or suggestions, please do let me know. I'll provide details for completed functionality Sunday night (US Eastern Time). Sorry for the silence for the past 3 months -- real-life is keeping me on my toes. [1]: https://github.com/psipika/lxpanel > With best regards, > Andriy. Best wishes! Piotr |
From: Daniele F. <df...@gm...> - 2013-01-16 21:57:27
Attachments:
clang.txt
|
2013/1/15 Piotr Sipika: > I would appreciate the community's feedback and would like to ask for > the plugin to be included in mainline LXPanel source. I like it and I would be happy to provide the Italian translation you may want to check the following error messages from cppcheck (to see them just run cppcheck src): [src/httputil.c:107]: (error) Common realloc mistake: 'pInBuffer' nulled but not freed upon failure [src/httputil.c:137]: (error) Common realloc mistake: 'pInBuffer' nulled but not freed upon failure [src/location.c:166]: (error) Possible null pointer dereference: pDestination - otherwise it is redundant to check if pDestination is null at line 146 [src/lxpanel_plugin/weather.c:146]: (error) Memory leak: pLocation [src/weatherwidget.c:1954]: (error) Possible null pointer dereference: location_data - otherwise it is redundant to check if location_data is null at line 1956 and the warnings from clang in the attached clang.txt file (the configure step used gcc, but then I ran: make CC="clang --analyze") when I run make clean I get this error: dh_clean: cannot read debian/control: No such file or directory -- Daniele Forsi |
From: Piotr S. <pio...@gm...> - 2013-01-16 22:01:55
|
Daniele, > I like it and I would be happy to provide the Italian translation > > you may want to check the following error messages from cppcheck (to > see them just run cppcheck src): <snip> > and the warnings from clang in the attached clang.txt file (the > configure step used gcc, but then I ran: make CC="clang --analyze") > > when I run make clean I get this error: > dh_clean: cannot read debian/control: No such file or directory Thank you for all that! Cheers! Piotr |