Menu

#892 lxpanel/cpu: panel font size configuration not honored

None
closed-accepted
lxpanel (297)
5
2018-01-08
2018-01-05
No

Related to https://sourceforge.net/p/lxde/bugs/890/ , lxpanel cpu plugin always ignores panel font size configuration, no matter how long user waits for such configuration to be applied.

Proposal patch attached.

1 Attachments

Discussion

  • Lonely Stranger

    Lonely Stranger - 2018-01-07

    Thank you very much. Overall it looks good but I would rather create new API lxpanel_draw_label_text_with_color() similar to lxpanel_draw_label_text() one and use it instead of all those changes:

    snprintf(buffer, sizeof(buffer), "%02d", temp);
    lxpanel_draw_label_text_with_color(th->panel, th->namew, buffer, TRUE, 1, &color);
    
     
  • Mamoru TASAKA

    Mamoru TASAKA - 2018-01-08

    Okay, thank you for review. I think your idea is much better, and I think the (newly) attached patch should follow your idea.

    Note that currently with this patch, I left APIs (of symbols) which are already visible outside unchanged, so I added some "wrapper" functions.

    And this is "thermal" plugin, not "cpu"... sorry.

     
  • Lonely Stranger

    Lonely Stranger - 2018-01-08
    • labels: lxpanel, cpu --> lxpanel
    • status: open --> closed-accepted
    • assigned_to: Lonely Stranger
    • Group: -->
     
  • Lonely Stranger

    Lonely Stranger - 2018-01-08

    Thank you very much. Pushed your change into GIT repository.

     

Log in to post a comment.

MongoDB Logo MongoDB