Menu

#786 [lxdm] Broken after commit: pass xauth file to xserver command

None
closed-fixed
dgod.osa
lxdm (80)
5
2015-11-24
2015-11-08
No

This commit breaks LXDM on my system:
http://git.lxde.org/gitweb/?p=lxde/lxdm.git;a=commitdiff;h=e8f387089e241360bdc6955d3e479450722dcea3

I can see only a blank screen. It looks like X runs, but LXDM quit as soon as started.

Discussion

1 2 > >> (Page 1 of 2)
  • dgod.osa

    dgod.osa - 2015-11-08

    I have run this version stable, so please provide more infomation.

     
  • Mamoru TASAKA

    Mamoru TASAKA - 2015-11-20

    I don't know the detailed configuration of this reporter, however an user using NFS-mounted directory as home directory is now seeing this:

    https://bugzilla.redhat.com/show_bug.cgi?id=1283581

    I have not tried this myself, although.

     
  • dgod.osa

    dgod.osa - 2015-11-20

    So the problem is user can't work correctly after login, not the lxdm itself quit.
    In my opinion, The analysis https://bugzilla.redhat.com/show_bug.cgi?id=1283581 is correct.
    So the only workaround is set xauth_path now.

     
  • Balló György

    Balló György - 2015-11-20

    No, it's a different problem. I can see only a blank screen after this commit. LXDM does not load for me. What information do you need?

     
  • Mamoru TASAKA

    Mamoru TASAKA - 2015-11-20

    For NFS problem, I think when writing user's ~/.Xauthority, lxdm should first drop its priviledges first and write it, and restore its priviledges.

    So while I am waiting the downstream bug reporter's feedback, I think the attached patch should do the work (patch is against 0.5.2)

    And maybe set_face_file() should fix similarly.

     
    • dgod.osa

      dgod.osa - 2015-11-20

      this patch only works if xauth file is at ~/, if pam or config file provide somewhere need root, it will fail.

       
      • Mamoru TASAKA

        Mamoru TASAKA - 2015-11-20

        Then lxdm-binary should try writing as root first then chown, and if it fails write it as user's priviledges.
        (and anyway I think set_face_file() should be fixed)

         

        Last edit: Mamoru TASAKA 2015-11-20
        • dgod.osa

          dgod.osa - 2015-11-20

          That's strange, root should be can do everything on unix. another problem is ~/ is readonly filesystem.

           
          • Mamoru TASAKA

            Mamoru TASAKA - 2015-11-20

            Okay, after some googling looks like setting Xauthority file to DM specific directory seems preferable.

             
  • Balló György

    Balló György - 2015-11-22

    I attached the lxdm.log with LXDM from current git master. Appearantly, the X server opens on VT7 with blank screen instread on the configured VT1. I'm using xorg-server 1.17.4.

     
  • dgod.osa

    dgod.osa - 2015-11-23

    I google the web, the error most likely happen when user use X11 over network, do you use local machine to test or over ssh?

     
  • Balló György

    Balló György - 2015-11-23

    I'm using a local virtual machine for the test.

     
  • dgod.osa

    dgod.osa - 2015-11-23

    one possible reason is your system have "lxdm" user, just delete it.

     
  • Balló György

    Balló György - 2015-11-23

    Yes, I have "lxdm" user, which is created automatically on Arch Linux a long time ago. Why should I delete it? Are you sure that it's better to run lxdm greeter as root?

     
  • Mamoru TASAKA

    Mamoru TASAKA - 2015-11-23

    BTW, the downstream reporter says NFS issue is fixed with the latest git.

     
  • dgod.osa

    dgod.osa - 2015-11-23

    "lxdm" user problem fixed in git now, if you can confirm it I will release 0.5.3

     
    • Lonely Stranger

      Lonely Stranger - 2015-11-23

      That is perfect! I would like you to release it into http://sourceforge.net/projects/lxde/files/lxdm/ rather than somewhere else. Thank you very much!

       
  • Balló György

    Balló György - 2015-11-23

    I confirm that it's fixed now. Thanks!

     
  • dgod.osa

    dgod.osa - 2015-11-24

    I don't have write access to lxde project.

    I have upload 0.5.3 version at https://sourceforge.net/projects/lxdm/files/lxdm%200.5.3/

     
    • Lonely Stranger

      Lonely Stranger - 2015-11-24

      It cannot be, you are in list of Release Technicians for LXDE so should have full admin access to the files of LXDE. When it was last time you've tried it? Possibly it was in the time when sourceforge migrated to new site and there were a lot of problems with it.

       
      • dgod.osa

        dgod.osa - 2015-11-25

        Try upload today, still don't have permission.

         
        • Lonely Stranger

          Lonely Stranger - 2015-11-25

          Could you come to #lxde channel @ OFTC, please? I see nothing wrong with your permissions, I even made a test user to check and I could add and delete folder from that user without any problem. So I would like to check everything in real time, talking with you. Thank you in advance.

           
          • dgod.osa

            dgod.osa - 2015-11-25

            I have uploaded the file now, maybe something changed?

             
            • Lonely Stranger

              Lonely Stranger - 2015-11-25

              Thank you very much! I have no idea, may be adding test user then removing it refreshed your status in their database. Anyway, that's very good the problem is fixed now.

               
1 2 > >> (Page 1 of 2)

Log in to post a comment.