#766 window_manager doesn't get converted to windows_manager, openbox won't launch

[Mamoru TASAKA]

Downside report:
https://bugzilla.redhat.com/show_bug.cgi?id=1242273

Using lxsession 0.5.4

With lxde-common 0.99.0, desktop.conf contains

[Session]
window_manager=openbox-lxde

, not windows_manager/command or so.

With this, (with implicit default "guess_default=true",) (as far as I read
the code) window_manager is expected to be converted with
windows_manager/command or so, however actually this does not happen and
openbox won't launch by default.

With enabling some debugging output on lxsession-0.5.4/lxsession/settings.vala,
~/.cache/lxsession/LXDE/run.log contains lines like:

** Message: settings.vala:637: Create new config key: Session;window_manager;;

** (lxsession:16478): CRITICAL **: lxsession_lxsession_config_create_config_item: assertion 'key2 != NULL' failed

(the above line number may differ)

[Mamoru TASAKA]

So read_key_value() may be called with key2 = null, however
currently create_config_item() does not allow it because of
missing "?" on key2.

I think the attached patch should fix this issue.

By the way, even after applying this patch, I still see
the following messages:

** (lxsession:23744): CRITICAL **: lxsession_lxsession_config_set_config_item_value: assertion 'dbus_arg != NULL' failed

Maybe dbus_arg handling should be fixed similarly.

[gilir]

Thanks, I pushed the fix in git, let me know if it fixed the problem for you.