From: Robert W. <ro...@us...> - 2004-01-05 19:47:37
|
Applied to CVS...thanks! -Robbie Robert V. Williamson <ro...@us...> Linux Test Project IBM Linux Technology Center Web: http://ltp.sourceforge.net IRC: #ltp on freenode.irc.net ==================== "Only two things are infinite, the universe and human stupidity, and I'm not sure about the former." -Albert Einstein Erik Andersen <and...@co...> To: ltp...@li... Sent by: cc: ltp...@li...ur Subject: [LTP] Bogus test in mallopt01.c ceforge.net 12/30/2003 05:22 AM Please respond to andersen The (non SuSv3) function mallopt() is tested by ltp. On line 88 of mallopt01.c, the test checks if usmblks happens to equal 0. It just so happens that usmblks is set to 0 in glibc when threading is enabled, but testing if usmblks is set to 0 is meaningless, and produces incorrect results when glibc is built without thread support, and when used with uClibc (which does not force usmblks to 0 when threads are enabled). I recommend removing the pointless and apparently incorrect usmblks test from line 88 of mallopt01.c. --- ltp-full-20031204/testcases/kernel/syscalls/mallopt/mallopt01.orig.c +++ ltp-full-20031204/testcases/kernel/syscalls/mallopt/mallopt01.c @@ -85,11 +85,6 @@ flag = 1; local_flag = FAILED; }; - if (info.usmblks != 0) { - fprintf(temp, "mallinfo failed: usmblks != 0\n"); - flag = 1; - local_flag = FAILED; - } if (info.smblks != 0) { fprintf(temp, "mallinfo failed: smblks != 0\n"); flag = 1; -Erik -- Erik B. Andersen http://codepoet-consulting.com/ --This message was written using 73% post-consumer electrons-- ------------------------------------------------------- This SF.net email is sponsored by: IBM Linux Tutorials. Become an expert in LINUX or just sharpen your skills. Sign up for IBM's Free Linux Tutorials. Learn everything from the bash shell to sys admin. Click now! http://ads.osdn.com/?ad_id=1278&alloc_id=3371&op=click _______________________________________________ Ltp-list mailing list Ltp...@li... https://lists.sourceforge.net/lists/listinfo/ltp-list |