Re: [LTP] [PATCH 1/3] lib/test_net.sh: add tst_ping() to check icmp connectivity

[Alexey K. <ale...@or...>]

Hi,
On 03/07/2016 10:01 AM, Hangbin Liu wrote:
> Signed-off-by: Hangbin Liu <ha...@re...>
> ---
>   testcases/lib/test_net.sh | 37 +++++++++++++++++++++++++++++++++++++
>   1 file changed, 37 insertions(+)
>
> diff --git a/testcases/lib/test_net.sh b/testcases/lib/test_net.sh
> index 418fed3..f75e78e 100644
> --- a/testcases/lib/test_net.sh
> +++ b/testcases/lib/test_net.sh
> @@ -314,3 +314,40 @@ tst_netload()
>   
>   	return $ret
>   }
> +
> +# tst_ping IFACE ADDR [SIZE]
> +# Check icmp connectivity
> +# IFACE: source interface name
> +# ADDR: destination IPv4 or IPv6 address
> +# SIZE: message size
> +tst_ping()
> +{
> +	# The max number of ICMP echo request
> +	PING_MAX=${PING_MAX:-"10"}
> +
> +	# Check the arguments
> +	if [ $# -lt 2 ]; then
> +		tst_resm TBROK "tst_ping src_iface dest_ipv4/6_addr [msg_size]"
> +		return 1
> +	fi
> +
> +	local src_iface=$1
> +	local dst_addr=$2

They could be defaulted to $(tst_iface) and $(tst_ipaddr rhost) accordingly.
Then, we don't have to check the number of arguments and it fits for the 
most cases.

> +	# ping cmd use 56 as default message size
> +	local msg_size=${3:-"56"}
> +
> +	if echo $dst_addr | grep ":"; then
> +		local PING="ping6"
> +		TST_IPV6=6
> +	else
> +		local PING="ping"
> +	fi
> +

if test runs with -6 option, TST_IPV6 will be defined as 6, otherwise is "".
We can use it inside test_net.sh and tests. So here, we could call ping 
command
as follows: "ping$TST_IPV6 ..."


> +	if [ "$dst_addr" == "$(tst_ipaddr)" ]; then
> +		tst_rhost_run -c "$PING -I $src_iface -c $PING_MAX $dst_addr \
> +			-s $msg_size > /dev/null 2>&1"
> +	else
> +		$PING -I $src_iface -c $PING_MAX $dst_addr -s $msg_size > \
> +			/dev/null 2>&1
> +	fi
> +}

Do we actually need to run this command from remote host?

Best regards,
Alexey