Re: [LTP] [RFC][PATCH] partrt_nohz_full: Introducing a new test case

[Mats L. <mat...@en...>]

On Wed, 23 Apr 2014 12:24:36 +0200
<ch...@su...> wrote:

> Hi!
> > I've thought about this. The problem is that these tools is only
> > one way of doing it. Performing CPU isolation in Linux is still
> > something of a black art, so my idea was to show one way that we
> > have got it working for at least some boards. Since how to do this
> > is also dependent on architecture, board, kernel version and kernel
> > configuration I didn't want to tie these script too closely to the
> > test case since the test case by itself is quite generic.
> > 
> > Having these tools as copies in LTP repository gives additional
> > maintenance burden that I feel is unnecessary. The tools are needed
> > for other purposes as well, so moving them to LTP is not an option.
> > 
> > But if you have a good idea how to solve this dilemma, I'd like to
> > hear about it.
> 
> The best solution I can think of is to add the rt-tools as a git
> submodule in utils directory and install the required scripts on
> make install if submodules were initialized and pulled.
> 
> On the test side we need to check if these scripts are in $PATH and
> exit with TCONF if not.
> 
> Does this sound reasonable?
> 

It puts some requirements on whoever clones ltp to know that you have
to clone recursively to get everything. You also need to be aware of
the fact that the sub-directory is actually another repository in case
you want to commit.

But personally I don't have any real objections to it.

Regards
Mats Liljegren