Re: [Ltp-commits] [patch] Power Management: add notification once 'sched_debug' not in boot cmdline

[Garrett C. <yan...@gm...>]

On Mon, Jan 30, 2012 at 7:36 PM, Xu, Anhua <anh...@in...> wrote:
> Yes, agreed.  Since only sched_domain.py use this part of code. So I change the patch like this: once we find "sched_debug" is not in /proc/cmdline, we will not run sched_domain.py associated tests.
> ( or other actions to make the people aware that they miss kernel parameter "sched_debug")
>
> diff --git a/testcases/kernel/power_management/runpwtests.sh b/testcases/kernel/power_management/runpwtests.sh
> index c4a1d39..abe1d79 100755
> --- a/testcases/kernel/power_management/runpwtests.sh
> +++ b/testcases/kernel/power_management/runpwtests.sh
> @@ -191,7 +191,7 @@ if ! type python > /dev/null ; then
>        tst_resm TCONF "Python is not installed, CPU Consoldation\
>  test cannot run"
>  else
> -       if [ -f /sys/devices/system/cpu/sched_mc_power_savings ] ; then
> +       if [ -f /sys/devices/system/cpu/sched_mc_power_savings ] && grep sched_debug -w /proc/cmdline &> /dev/null; then

'&>' is a bashism. Please use 'grep -q sched_debug /proc/cmdline' instead

>                echo "max sched mc $max_sched_mc"
>                for sched_mc in `seq 0 $max_sched_mc`; do
>                        : $(( TST_COUNT+=1))

Thanks,
-Garrett