Re: [LTP] [PATCH] redefine NCPU = sysconf(_SC_NPROCESSORS_CONF)

[Cyril H. <ch...@su...>]

Hi!
> > > > I think using cat /proc/cpuinfo get core number is better.
> > > 
> > > But /proc/cpuinfo may not be supported by other OS.
> > 
> > Yes, procfs is linux specific.
> 
> no, it's not.  but much of the stuff that linux puts under /proc is Linux 
> specific like "cpuinfo".  in fact, the format of "cpuinfo" under Linux tends to 
> change based on the arch you're running on ...

Ah, right, I didn't know that procfs was there before Linux (anyway most
of the systems store process exports only related data there at least
google suggets that), but still it's not good idea not to use cpuinfo in
open posix testsuite...

> since this patch is against the open_posix_testsuite, we need to stick to 
> POSIX APIs (although, the forking of open_posix_testsuite in ltp is pretty 
> awful in general).  if it were against a different tree, then not caring about 
> non-Linux would be fine.

Well, the open posix testsuite project seems to be dead for some time
(at least four years) so having fork is only natural. Do you know some
of the original authors? Maybe we can just ask them to update the
sf.net pages to redirect people to LTP.

-- 
Cyril Hrubis
ch...@su...