From: Caspar Z. <cz...@re...> - 2011-05-06 03:45:05
|
On 04/27/2011 05:30 PM, Caspar Zhang wrote: > On 04/27/2011 02:40 AM, Garrett Cooper wrote: >> On Apr 26, 2011, at 9:50 AM, Caspar Zhang <cz...@re...> wrote: >> >>> On 04/27/2011 12:54 AM, Cyril Hrubis wrote: >>>> Hi! >>>> Git is not CVS (and understands patches that removes directories), so >>>> please provide patch that removes the libmm directory too. >>>> >>> >>> Hi, IIRC, GIT would remove the empty automatically while CVS would't. >>> Maybe I'm wrong, but I tested my patch by "git am -3", the libmm >>> directory did gone: >>> >>> $ ls testcases/kernel/mem/ | grep lib >>> lib >>> libmm >>> $ git am -3 ~/Desktop/\[PATCH\]\ \[mm\]\ remove\ unused\ libmm.eml >>> Applying: remove unused libmm >>> $ ls testcases/kernel/mem/ | grep lib >>> lib >> >> Honestly though -- it's easy enough to do a git rm on the directory, as long as everything was properly disabled beforehand, so it doesn't break the build like it has a handful of times for me. >> Thanks! >> -Garrett > > Hi Garrett and Cyril, I'm not very clear what I can do next to get this > merged to upstream. I have tested the patch on my own and the build > could finish successfully in any directory under mem/ dir. > > Caspar Hi, any suggestions? Thanks, Caspar |