From: Rishi k. K R. <ris...@li...> - 2010-03-23 08:59:21
|
The branch, master, has been updated via b72a24c9eb339841a0c4b82d384a5b3ba10c9ecb (commit) via f102fd9735f01b4e2c9ae44f3c90d1a56d4d81f8 (commit) via 965127e99f1c3e4035a3de621ca0c295de14448b (commit) via 0a52859d55cf93cdd310ec678868cb4d10e80728 (commit) via d05498f44de5d3e542b2031b458d84e907604728 (commit) via 2784e9a6e36cacad4192f41a8c9044a85428ed27 (commit) via 615e1e37de053855b6bd56bae8b00d8a17133f8a (commit) via b8ed5460176838d9b714dddbc17685983b4a8b9b (commit) via e8e3c7598b82b54a7770c48a2422d5d6fa127045 (commit) from 96a4822d72478abce6dceabc816f658ba4ded0d3 (commit) - Log ----------------------------------------------------------------- commit b72a24c9eb339841a0c4b82d384a5b3ba10c9ecb Merge: 96a4822d72478abce6dceabc816f658ba4ded0d3 f102fd9735f01b4e2c9ae44f3c90d1a56d4d81f8 Author: Rishikesh K Rajak <ris...@li...> Date: Tue Mar 23 14:26:21 2010 +0530 Merge branches 'maint' and 'master' commit f102fd9735f01b4e2c9ae44f3c90d1a56d4d81f8 Author: Rishikesh K Rajak <ris...@li...> Date: Tue Mar 23 14:20:36 2010 +0530 I have tested these on MIPS architecture and reproduced infinite waiting situation after applying this patch. (with strace no issue found ex: #strace ./8-1.test) As you said there may be issues in MIPS-POSIX library. it may take some time to fix these issues or may not be fixed. However, Iâll discuss this issue with MIPS folks in different thread. ATM, my patch is not a good idea for MIPS architectures. So, after your comments I have modified my patch and tested. Here in this latest patch i did not change any thing regarding while loop. I replaced sleep() in an appropriate place. It is working fine on X86, ARM and MIPS. Signed-off-by: Naresh Kamboju < nar...@gm... > Signed-off-by: Rishikesh K Rajak <ris...@li...> ----------------------------------------------------------------------- Summary of changes: testcases/network/multicast/mc_cmds/mc_cmds | 2 +- .../conformance/interfaces/sem_post/8-1.c | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/testcases/network/multicast/mc_cmds/mc_cmds b/testcases/network/multicast/mc_cmds/mc_cmds index d537103..f43dd95 100755 --- a/testcases/network/multicast/mc_cmds/mc_cmds +++ b/testcases/network/multicast/mc_cmds/mc_cmds @@ -127,7 +127,7 @@ for eth in $IFNAME cat /proc/sys/net/ipv4/icmp_echo_ignore_broadcasts | grep 1 > /dev/null if [ $? -eq 0 ] then - end_testcase "Multicast ping disabled on this system (this is normal on post 2005 kernels)" + end_testcase "Multicast ping disabled on this system (this is normal on post year:2005 kernels)" fi # Do the ping tests: Execute ping 224.0.0.1 - Verify that the proper diff --git a/testcases/open_posix_testsuite/conformance/interfaces/sem_post/8-1.c b/testcases/open_posix_testsuite/conformance/interfaces/sem_post/8-1.c index b2db995..86007b7 100644 --- a/testcases/open_posix_testsuite/conformance/interfaces/sem_post/8-1.c +++ b/testcases/open_posix_testsuite/conformance/interfaces/sem_post/8-1.c @@ -161,7 +161,6 @@ int main() } fprintf(stderr, "P: child_1:%d forked\n", c_1); - sleep(1); c_2 = fork(); if (c_2 == 0) { @@ -198,6 +197,9 @@ int main() //printf("val = %d\n", val); } while (val != 0); */ + + /* Synchronization required before release the lock */ + sleep(1); /* Ok, let's release the lock */ fprintf(stderr, "P: release lock\n"); sem_post(sem); hooks/post-receive -- ltp |