Re: [LTP] Missing test tools in recent ltp builds

[Garrett C. <yan...@gm...>]

On Wed, Mar 3, 2010 at 10:45 PM, Rishikesh K Rajak
<ris...@li...> wrote:
> On Wed, Mar 03, 2010 at 03:16:47PM -0800, Garrett Cooper wrote:
>> On Mar 3, 2010, at 9:00 AM, Maxin John <max...@gm...> wrote:
>>
>> > Hi Shwetabh,
>> >
>> >> 3. Went to /opt/ltp directory and tried to execute cpuhotplug test:
>> >> [root@localhost ~]# cd /opt/ltp/
>> >> [root@localhost ltp]# ./runltp -f cpuhotplug
>> >>
>> >
>> > Please find attached the quick 'n' dirty patch
>> > (cpu_hotplugin_makefile.patch) to execute cpuhotplugin test.
>> > I have observed that the 'hotplug' directory is not included in
>> > "testcases/kernel/Makefile". I have also
>> > created a Makefile in 'hotplug/cpu_hotplug' directory.
>> >
>> > After applying this patch, I have followed the usual ./configure;
>> > make; sudo make install steps and executed
>> > the cpuhotplug test and observed the below given output . It seems
>> > like the test execution is "not so good" in
>> > my machine. Your mileage may vary.
>> >
>> > Garret,Rishi, please review the patch and let me know your comments.
>> >
>> > Signed-off-by: Maxin B. John <max...@gm...>
>>
>> It looks better but it's going to need a minor amount of fudging in
>> the scripts to source the appropriate scripts to execute cpuhotplug's
>> tests... I'll pick this up tomorrow if it's not done by then...
>
> Yes it looks better, i have tested it and true there are still some
> problem with testcase, can you look very closely and try to find the
> root cause for that ? Since this patch is important to run cpuhotplug
> testcases, i have included this to master branch.

    I'm not arguing that it's a good step towards getting the task
solved; I'm arguing that the change wasn't complete. I'm cleaning it
up right now...
Thanks,
-Garrett