From: Garrett C. <yab...@us...> - 2010-02-09 14:49:11
|
Update of /cvsroot/ltp/ltp/testcases/kernel/security/cap_bound In directory sfp-cvsdas-2.v30.ch3.sourceforge.com:/tmp/cvs-serv21663/kernel/security/cap_bound Modified Files: exec_without_inh.c Log Message: An error occured on my i386 box. (OS: Fedora8, Kernel: 2.6.33-rc6, libcap: libcap-2.16) ------------- exec_without_inh 1 TFAIL : Failed to drop CAP_SYS_ADMIN from bounding set. exec_without_inh 0 TINFO : (ret=-1, errno 38) ------------- If the macro HAVE_DECL_CAP_BSET_DROP is 0, this error will occurs. But the program should to be broken when f != CAP_SET, like the similar code "if (ret || f != CAP_SET) {" in exec_with_inh.c. The TBROK message will be outputted if my patch merged. ------------- exec_without_inh 1 TBROK : Failed to add CAP_SYS_ADMIN to pI ------------- Signed-off-by: Shi Weihua <sh...@cn...> --- Index: exec_without_inh.c =================================================================== RCS file: /cvsroot/ltp/ltp/testcases/kernel/security/cap_bound/exec_without_inh.c,v retrieving revision 1.3 retrieving revision 1.4 diff -C2 -d -r1.3 -r1.4 *** exec_without_inh.c 9 Oct 2009 17:55:50 -0000 1.3 --- exec_without_inh.c 9 Feb 2010 14:49:02 -0000 1.4 *************** *** 79,83 **** tst_resm(TBROK, "Failed to drop cap_sys_admin from pI\n"); tst_exit(); ! } } #if HAVE_DECL_CAP_FREE --- 79,86 ---- tst_resm(TBROK, "Failed to drop cap_sys_admin from pI\n"); tst_exit(); ! i} ! } else if (ret) { ! tst_brkm(TBROK | TERRNO, tst_exit, "Failed to add \ ! CAP_SYS_ADMIN to pI"); } #if HAVE_DECL_CAP_FREE |