From: Garrett C. <yab...@us...> - 2010-01-31 01:52:07
|
Update of /cvsroot/ltp/ltp/testscripts/build In directory sfp-cvsdas-2.v30.ch3.sourceforge.com:/tmp/cvs-serv4180 Modified Files: build_test_function.sh Log Message: Don't forget to call false in the event of setup failure because we don't want things to silently pass if the directories couldn't be created... Signed-off-by: Garrett Cooper <yan...@gm...> Index: build_test_function.sh =================================================================== RCS file: /cvsroot/ltp/ltp/testscripts/build/build_test_function.sh,v retrieving revision 1.5 retrieving revision 1.6 diff -C2 -d -r1.5 -r1.6 *** build_test_function.sh 31 Jan 2010 01:49:48 -0000 1.5 --- build_test_function.sh 31 Jan 2010 01:51:59 -0000 1.6 *************** *** 32,35 **** --- 32,36 ---- else echo "${0##*/}: failed to create tmp_builddir"; + false fi if tmp_destdir=$(mktemp -d) ; then *************** *** 37,40 **** --- 38,42 ---- else echo "${0##*/}: failed to create tmp_destdir"; + false fi if tmp_prefix=$(mktemp -d) ; then *************** *** 42,45 **** --- 44,48 ---- else echo "${0##*/}: failed to create tmp_prefix"; + false fi if tmp_srcdir=$(mktemp -d) ; then *************** *** 47,50 **** --- 50,54 ---- else echo "${0##*/}: failed to create tmp_srcdir"; + false fi trap cleanup EXIT |