[Ltp-cvs] ltp/testscripts Makefile, 1.2, 1.3 test_fs_bind.sh, 1.3, 1.4

[Garrett C. <yab...@us...>]

Update of /cvsroot/ltp/ltp/testscripts
In directory sfp-cvsdas-2.v30.ch3.sourceforge.com:/tmp/cvs-serv7864/testscripts

Modified Files:
	Makefile test_fs_bind.sh 
Log Message:
Apply the fix for the issue noted below.

Signed-off-by: Garrett Cooper <yan...@gm...>

Hi,

I ran "runltp" with "ltp-2009-12-16" cvs.
And I found the following failure in "BindMounts" testcase:

------------
sh: /opt/ltp/testscripts/test_fs_bind.sh: Permission denied
------------

When I added execution permission and tested this testcase, the
following errors occurred.

------------
ls: /opt/ltp/testcases/kernel/fs/fs_bind/move/test*: No such file or
directory
ls: /opt/ltp/testcases/kernel/fs/fs_bind/bind/test*: No such file or
directory
ls: /opt/ltp/testcases/kernel/fs/fs_bind/rbind/test*: No such file or
directory
ls: /opt/ltp/testcases/kernel/fs/fs_bind/regression/test*: No such file or
directory
------------

This error is caused by following:
 (1) Execution files haven't permissions.
 (2) "${LTPROOT}" directory isn't the current directory in which
    "make install" executed.
    By default, "${LTPROOT}" directory is "/opt/ltp".
 (3) ".../ltp-2009-12-16/testcases/kernel/fs/fs_bind/" directory does exist,
    but "/opt/ltp/testcases/kernel/fs/fs_bind/" directory doesn't exist.
     (I want to suggest using "/opt/ltp/testcases/bin/fs_bind/"
     instead of "/opt/ltp/testcases/kernel/fs/fs_bind/".)

Then, I think that it requires following three modifications to run
"BindMounts" test exactly:

 (1) Add the execution permissions to "${LTPROOT}/testscripts" directory
    when installation.
 (2) Deploy following four directories under the "${LTPROOT}/testcases/bin"
    directory when installation.
    "./fs_bind/move/"
    "./fs_bind/bind/"
    "./fs_bind/rbind/"
    "./fs_bind/regression/"
 (3) Apply the following patch:
============
--- test_fs_bind.sh     2008-06-29 04:30:19.000000000 +0900
+++ test_fs_bind.sh.new 2009-12-17 11:32:27.000000000 +0900
@@ -60,7 +60,7 @@
               LTPROOT="${PWD}"
       fi

-       FS_BIND_ROOT="${LTPROOT}/testcases/kernel/fs/fs_bind"
+       FS_BIND_ROOT="${LTPROOT}/testcases/bin/fs_bind"

       total=0 # total number of tests
       for dir in "${test_dirs[@]}" ; do
============


Regards--


-Tomonori Mitani



Index: Makefile
===================================================================
RCS file: /cvsroot/ltp/ltp/testscripts/Makefile,v
retrieving revision 1.2
retrieving revision 1.3
diff -C2 -d -r1.2 -r1.3
*** Makefile	11 Dec 2009 15:38:21 -0000	1.2
--- Makefile	22 Dec 2009 03:28:25 -0000	1.3
***************
*** 27,31 ****
  INSTALL_DIR		:= testscripts
  
! INSTALL_MODE		:= 00644
  
  INSTALL_TARGETS		:= *.sh
--- 27,31 ----
  INSTALL_DIR		:= testscripts
  
! INSTALL_MODE		:= 00755
  
  INSTALL_TARGETS		:= *.sh

Index: test_fs_bind.sh
===================================================================
RCS file: /cvsroot/ltp/ltp/testscripts/test_fs_bind.sh,v
retrieving revision 1.3
retrieving revision 1.4
diff -C2 -d -r1.3 -r1.4
*** test_fs_bind.sh	28 Jun 2008 19:30:19 -0000	1.3
--- test_fs_bind.sh	22 Dec 2009 03:28:25 -0000	1.4
***************
*** 61,65 ****
  	fi
  	
! 	FS_BIND_ROOT="${LTPROOT}/testcases/kernel/fs/fs_bind"
  
  	total=0 # total number of tests
--- 61,65 ----
  	fi
  	
! 	FS_BIND_ROOT="${LTPROOT}/testcases/bin/fs_bind"
  
  	total=0 # total number of tests