From: Subrata <sub...@us...> - 2009-06-09 16:01:28
|
Update of /cvsroot/ltp/ltp/testcases/kernel/syscalls/setpgrp In directory ddv4jf1.ch3.sourceforge.com:/tmp/cvs-serv1759/ltp/testcases/kernel/syscalls/setpgrp Modified Files: setpgrp01.c Log Message: Test library cleanups: Removing no longer used code from test.h eg. test_error.c is no longer in ltp, and the same for t_res.c so there is no need to include function prototypes for these. Adding void to functions that doesn't take any parameters; tst_exit() -> tst_exit(void); so code that pases parameters to these is not compileable any more. Also fixes all test broken by that change. As parameters passed to tst_exit() are ignored anyway it's quite safe to just remove them; but I'would rather see someone take a closer look. Code cleanups and fixes in tst_res.c: * removed trivial and useless comments, * cleaned coding style, * and much more, TODO: there is much redundant code in tst_res.c I'll eliminate that by static functions. Signed-off-by: ch...@su.... Index: setpgrp01.c =================================================================== RCS file: /cvsroot/ltp/ltp/testcases/kernel/syscalls/setpgrp/setpgrp01.c,v retrieving revision 1.5 retrieving revision 1.6 diff -C2 -d -r1.5 -r1.6 *** setpgrp01.c 23 Mar 2009 13:36:04 -0000 1.5 --- setpgrp01.c 9 Jun 2009 16:01:21 -0000 1.6 *************** *** 136,140 **** if ((msg = parse_opts(ac, av, (option_t *) NULL, NULL)) != (char *)NULL) { tst_brkm(TBROK, NULL, "OPTION PARSING ERROR - %s", msg); ! tst_exit(0); } --- 136,140 ---- if ((msg = parse_opts(ac, av, (option_t *) NULL, NULL)) != (char *)NULL) { tst_brkm(TBROK, NULL, "OPTION PARSING ERROR - %s", msg); ! tst_exit(); } |