Re: [LTP] [PATCH] sockioctl0 fix to stop relying on existing tty*

[Henry Y. <hy...@mv...>]

Sorry, there was a missing character in the patch. I've attached the
updated patch. 

Post patch:
<<<test_start>>>
tag=sockioctl01 stime=1209163764
cmdline="sockioctl01"
contacts=""
analysis=exit
initiation_status="ok"
<<<test_output>>>
sockioctl01    1  PASS  :  bad file descriptor successful
sockioctl01    2  PASS  :  not a socket successful
sockioctl01    3  PASS  :  invalid option buffer successful
sockioctl01    4  PASS  :  ATMARK on UDP successful
sockioctl01    5  PASS  :  SIOCGIFCONF successful
sockioctl01    6  PASS  :  SIOCGIFFLAGS successful
sockioctl01    7  PASS  :  SIOCGIFFLAGS with invalid ifr successful
sockioctl01    8  PASS  :  SIOCSIFFLAGS with invalid ifr successful
incrementing stop
<<<execution_status>>>
duration=0 termination_type=exited termination_id=0 corefile=no
cutime=0 cstime=0
<<<test_end>>>

Prepatch:
<<<test_start>>>
tag=sockioctl01 stime=1193788811
cmdline="sockioctl01"
contacts=""
analysis=exit
initiation_status="ok"
<<<test_output>>>
sockioctl01    1  PASS  :  bad file descriptor successful
sockioctl01    2  BROK  :  Could not open /dev/tty0 or /dev/tty - errno:
No such device or address
sockioctl01    3  BROK  :  Remaining cases broken
sockioctl01    4  BROK  :  Remaining cases broken
sockioctl01    5  BROK  :  Remaining cases broken
sockioctl01    6  BROK  :  Remaining cases broken
sockioctl01    7  BROK  :  Remaining cases broken
sockioctl01    8  BROK  :  Remaining cases broken
<<<execution_status>>>
duration=0 termination_type=exited termination_id=2 corefile=no
cutime=0 cstime=0
<<<test_end>>>

-----Original Message-----
From: Subrata Modak [mailto:su...@li...] 
Sent: Friday, April 25, 2008 12:20 PM
To: Henry Yei
Cc: ltp...@li...
Subject: Re: [LTP] [PATCH] sockioctl0 fix to stop relying on existing
tty*

On Thu, 2008-04-24 at 19:47 -0700, Henry Yei wrote:
> Hello,
> 
> This patch removes the dependency of existing tty* devices for this 
> test to pass, and also ups the invalid file descriptor value from 400 
> to 1025 which is used to confirm the EBADF errno.

But i get a testcase failure after applying the Patch. Please see below
the results:

<<<test_start>>>
tag=sockioctl01 stime=1209151071
cmdline="sockioctl01"
contacts=""
analysis=exit
initiation_status="ok"
<<<test_output>>>
incrementing stop
sockioctl01    1  PASS  :  bad file descriptor successful
sockioctl01    0  WARN  :  tst_rmdir(): TESTDIR was NULL; no removal
attempted
sockioctl01    2  FAIL  :  not a socket ; returned -1 (expected -1),
errno 25 (expected 22)
sockioctl01    3  PASS  :  invalid option buffer successful
sockioctl01    4  PASS  :  ATMARK on UDP successful
sockioctl01    5  PASS  :  SIOCGIFCONF successful
sockioctl01    6  PASS  :  SIOCGIFFLAGS successful
sockioctl01    7  PASS  :  SIOCGIFFLAGS with invalid ifr successful
sockioctl01    8  PASS  :  SIOCSIFFLAGS with invalid ifr successful
<<<execution_status>>>
duration=0 termination_type=exited termination_id=5 corefile=no cutime=0
cstime=0 <<<test_end>>>

$ uname -a
Linux <sniff> 2.6.18-53.1.13.el5 #1 SMP Mon Feb 11 13:27:52 EST 2008
i686 i686 i386 GNU/Linux

Test Executes fine pre-patch. It would be nice if you can share your
test results pre and post-patch.



Regards--
Subrata

> 
> Henry Yei
> MontaVista Software, Inc.
> hy...@mv...
>  
> ----------------------------------------------------------------------
> --- This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
> Don't miss this year's exciting event. There's still time to save
$100.
> Use priority code J8TL2D2. 
> http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com
> /javaone _______________________________________________ Ltp-list 
> mailing list Ltp...@li... 
> https://lists.sourceforge.net/lists/listinfo/ltp-list