From: Robert W. <ro...@us...> - 2003-03-28 19:18:11
|
Below are the only "errors" your should see when building the LTP. In most of these cases, the filename was required, and since mkstemp() only returns an fd, I couldn't use it.......without having to do more testcase re-writing than I wanted to. However, to all who wish to see a complete "error free" LTP compile, I'm willing to accept your patches ;) -Robbie ==================== "Only two things are infinite, the universe and human stupidity, and I'm not sure about the former." -Albert Einstein --------------------------------------------------------- growfiles.o: In function `main': growfiles.o(.text+0x1b60): the use of `tempnam' is dangerous, better use `mkstemp' /tmp/ccU6hXya.o: In function `mkfile': /usr/local/ltp/testcases/kernel/mem/mtest06/mmap1.c:268: the use of `tempnam' is dangerous, better use `mkstemp' /tmp/ccOfUepQ.o: In function `mkfile': /usr/local/ltp/testcases/kernel/mem/mtest06/mmap2.c:103: the use of `tempnam' is dangerous, better use `mkstemp' /tmp/cc0a23NQ.o: In function `mkfile': /usr/local/ltp/testcases/kernel/mem/mtest06/mmap3.c:106: the use of `tempnam' is dangerous, better use `mkstemp' /tmp/cc28oChl.o: In function `setup': /usr/local/ltp/testcases/kernel/syscalls/fcntl/fcntl06.c:155: the use of `tempnam' is dangerous, better use `mkstemp' /tmp/cctlIBmA.o: In function `setup': /usr/local/ltp/testcases/kernel/syscalls/fcntl/fcntl11.c:121: the use of `tempnam' is dangerous, better use `mkstemp' /tmp/ccw9BECp.o: In function `setup': /usr/local/ltp/testcases/kernel/syscalls/fcntl/fcntl17.c:124: the use of `tempnam' is dangerous, better use `mkstemp' /tmp/ccLdoUbo.o: In function `setup': /usr/local/ltp/testcases/kernel/syscalls/fcntl/fcntl19.c:104: the use of `tempnam' is dangerous, better use `mkstemp' /tmp/ccFPM0Ha.o: In function `setup': /usr/local/ltp/testcases/kernel/syscalls/fcntl/fcntl20.c:101: the use of `tempnam' is dangerous, better use `mkstemp' /tmp/ccXdowX0.o: In function `setup': /usr/local/ltp/testcases/kernel/syscalls/fcntl/fcntl21.c:100: the use of `tempnam' is dangerous, better use `mkstemp' /tmp/cchlXkFz.o: In function `setup': /usr/local/ltp/testcases/kernel/syscalls/sendmsg/sendmsg01.c:328: the use of `mktemp' is dangerous, better use `mkstemp' |
From: Paul L. <pl...@li...> - 2003-03-28 21:33:22
|
On Fri, 2003-03-28 at 13:17, Robert Williamson wrote: > Below are the only "errors" your should see when building the LTP. In most > of these cases, the filename was required, and since mkstemp() only returns > an fd, I couldn't use it.......without having to do more testcase > re-writing than I wanted to. However, to all who wish to see a complete > "error free" LTP compile, I'm willing to accept your patches ;) actually we used to have a lot more of these. I went through and cleaned them all (I thought) up a long time ago. Either these tests have been added since then or I missed a few. If I get a chance I'll try to go back and get these too. -Paul Larson |
From: Nathan S. <ns...@sg...> - 2003-03-28 21:55:15
|
On Fri, Mar 28, 2003 at 04:39:09PM -0600, Paul Larson wrote: > On Fri, 2003-03-28 at 13:17, Robert Williamson wrote: > > Below are the only "errors" your should see when building the LTP. In most > > of these cases, the filename was required, and since mkstemp() only returns > > an fd, I couldn't use it.......without having to do more testcase > > re-writing than I wanted to. However, to all who wish to see a complete > > "error free" LTP compile, I'm willing to accept your patches ;) > > actually we used to have a lot more of these. I went through and > cleaned them all (I thought) up a long time ago. Either these tests > have been added since then or I missed a few. If I get a chance I'll > try to go back and get these too. FYI, the library function tst_tmpdir() uses mkdtemp() when possible. Other wise it uses mkstemp() and replaces the file with a directory. Test cases should be using tst_tmpdir() where possible. -- Nate Straz ns...@sg... sgi, inc http://www.sgi.com/ Linux Test Project http://ltp.sf.net/ |