From: Garrett C. <yan...@gm...> - 2012-04-05 00:46:24
|
Replace struct event_t with struct inotify_event Also do some minor whitespace cleanup while I'm in the neighborhood. Signed-off-by: Garrett Cooper <yan...@gm...> --- testcases/kernel/syscalls/inotify/inotify02.c | 13 ++++--------- 1 files changed, 4 insertions(+), 9 deletions(-) --------------1.7.2.5 Content-Type: text/x-patch; name="0002-Replace-struct-event_t-with-struct-inotify_event.patch" Content-Transfer-Encoding: 8bit Content-Disposition: attachment; filename="0002-Replace-struct-event_t-with-struct-inotify_event.patch" diff --git a/testcases/kernel/syscalls/inotify/inotify02.c b/testcases/kernel/syscalls/inotify/inotify02.c index 59f83ba..c87797f 100644 --- a/testcases/kernel/syscalls/inotify/inotify02.c +++ b/testcases/kernel/syscalls/inotify/inotify02.c @@ -81,15 +81,10 @@ char buf[BUF_SIZE]; int fd, fd_notify; int wd; -struct event_t { - char name[BUF_SIZE]; - int mask; - int len; -}; #define FILE_NAME1 "test_file1" #define FILE_NAME2 "test_file2" -struct event_t event_set[EVENT_MAX]; +struct inotify_event event_set[EVENT_MAX]; char event_buf[EVENT_BUF_LEN]; @@ -239,7 +234,7 @@ int main(int ac, char **av) "1c17d18e3775485bf1e0ce79575eb637a94494a2."); tst_resm(TFAIL, "get unnecessary event: " - "wd=%d mask=%x cookie=%u len=%u" + "wd=%d mask=%x cookie=%u len=%u " "name=\"%s\"", event->wd, event->mask, event->cookie, event->len, event->name); @@ -250,8 +245,8 @@ int main(int ac, char **av) (event_set[test_num].name, event->name, event->len))) { tst_resm(TPASS, - "get event: wd=%d mask=%x" - " cookie=%u len=%u name=\"%s\"", + "get event: wd=%d mask=%x " + "cookie=%u len=%u name=\"%s\"", event->wd, event->mask, event->cookie, event->len, event->name); |
From: Wanlong G. <gao...@cn...> - 2012-04-05 01:40:49
|
On 04/05/2012 08:42 AM, Garrett Cooper wrote: > Replace struct event_t with struct inotify_event > > Also do some minor whitespace cleanup while I'm > in the neighborhood. Cooper, there's something wrong with this patch, please take a look at the ".name". inotify02 1 TPASS : get event: wd=1 mask=40000004 cookie=0 len=0 name="" inotify02 2 TFAIL : get event: wd=1 mask=100 (expected 100) cookie=0 len=16 name="test_file1" (expected "test ") -63 inotify02 3 TFAIL : get event: wd=1 mask=20 (expected 20) cookie=0 len=16 name="test_file1" (expected "tes") -87 inotify02 4 TFAIL : get event: wd=1 mask=8 (expected 8) cookie=0 len=16 name="test_file1" (expected "test@") -31 inotify02 5 TFAIL : get event: wd=1 mask=40 (expected 40) cookie=1950 len=16 name="test_file1" (expected "test�") 33 inotify02 6 TFAIL : get event: wd=1 mask=80 (expected 80) cookie=1950 len=16 name="test_file2" (expected "test") -95 inotify02 7 TPASS : get event: wd=1 mask=800 cookie=0 len=0 name="" inotify02 8 TFAIL : get event: wd=1 mask=200 (expected 200) cookie=0 len=16 name="test_file2" (expected "test") -95 inotify02 9 TPASS : get event: wd=1 mask=800 cookie=0 len=0 name="" Thanks, Wanlong Gao > > Signed-off-by: Garrett Cooper <yan...@gm...> > > --- > testcases/kernel/syscalls/inotify/inotify02.c | 13 ++++--------- > 1 files changed, 4 insertions(+), 9 deletions(-) > > > --------------1.7.2.5 > Content-Type: text/x-patch; name="0002-Replace-struct-event_t-with-struct-inotify_event.patch" > Content-Transfer-Encoding: 8bit > Content-Disposition: attachment; filename="0002-Replace-struct-event_t-with-struct-inotify_event.patch" > > diff --git a/testcases/kernel/syscalls/inotify/inotify02.c b/testcases/kernel/syscalls/inotify/inotify02.c > index 59f83ba..c87797f 100644 > --- a/testcases/kernel/syscalls/inotify/inotify02.c > +++ b/testcases/kernel/syscalls/inotify/inotify02.c > @@ -81,15 +81,10 @@ char buf[BUF_SIZE]; > int fd, fd_notify; > int wd; > > -struct event_t { > - char name[BUF_SIZE]; > - int mask; > - int len; > -}; > #define FILE_NAME1 "test_file1" > #define FILE_NAME2 "test_file2" > > -struct event_t event_set[EVENT_MAX]; > +struct inotify_event event_set[EVENT_MAX]; > > char event_buf[EVENT_BUF_LEN]; > > @@ -239,7 +234,7 @@ int main(int ac, char **av) > "1c17d18e3775485bf1e0ce79575eb637a94494a2."); > tst_resm(TFAIL, > "get unnecessary event: " > - "wd=%d mask=%x cookie=%u len=%u" > + "wd=%d mask=%x cookie=%u len=%u " > "name=\"%s\"", event->wd, event->mask, > event->cookie, event->len, > event->name); > @@ -250,8 +245,8 @@ int main(int ac, char **av) > (event_set[test_num].name, event->name, > event->len))) { > tst_resm(TPASS, > - "get event: wd=%d mask=%x" > - " cookie=%u len=%u name=\"%s\"", > + "get event: wd=%d mask=%x " > + "cookie=%u len=%u name=\"%s\"", > event->wd, event->mask, event->cookie, > event->len, event->name); > > > ------------------------------------------------------------------------------ > Better than sec? Nothing is better than sec when it comes to > monitoring Big Data applications. Try Boundary one-second > resolution app monitoring today. Free. > http://p.sf.net/sfu/Boundary-dev2dev > > > > _______________________________________________ > Ltp-list mailing list > Ltp...@li... > https://lists.sourceforge.net/lists/listinfo/ltp-list |
From: Garrett C. <yan...@gm...> - 2012-04-05 02:10:35
|
On Wed, Apr 4, 2012 at 6:39 PM, Wanlong Gao <gao...@cn...> wrote: > On 04/05/2012 08:42 AM, Garrett Cooper wrote: > >> Replace struct event_t with struct inotify_event >> >> Also do some minor whitespace cleanup while I'm >> in the neighborhood. > > there's something wrong with this patch, please take a look at the ".name". Yeah... let me get back to you on that... -Garrett |
From: Wanlong G. <gao...@cn...> - 2012-04-11 02:54:18
|
On 04/05/2012 10:10 AM, Garrett Cooper wrote: > On Wed, Apr 4, 2012 at 6:39 PM, Wanlong Gao <gao...@cn...> wrote: >> On 04/05/2012 08:42 AM, Garrett Cooper wrote: >> >>> Replace struct event_t with struct inotify_event >>> >>> Also do some minor whitespace cleanup while I'm >>> in the neighborhood. >> >> there's something wrong with this patch, please take a look at the ".name". > > Yeah... let me get back to you on that... Any update on this? Thanks, Wanlong Gao > -Garrett > |
From: Garrett C. <yan...@gm...> - 2012-04-11 09:42:17
|
On Apr 10, 2012, at 7:53 PM, Wanlong Gao <gao...@cn...> wrote: > On 04/05/2012 10:10 AM, Garrett Cooper wrote: > >> On Wed, Apr 4, 2012 at 6:39 PM, Wanlong Gao <gao...@cn...> wrote: >>> On 04/05/2012 08:42 AM, Garrett Cooper wrote: >>> >>>> Replace struct event_t with struct inotify_event >>>> >>>> Also do some minor whitespace cleanup while I'm >>>> in the neighborhood. >>> >>> there's something wrong with this patch, please take a look at the ".name". >> >> Yeah... let me get back to you on that... > > > Any update on this? I'm moving from CA to WA, but I'll try to get back to you sometime mid next week once I get settled in. Thanks! -Garrett |
From: Wanlong G. <gao...@cn...> - 2012-04-11 09:35:09
|
On 04/11/2012 05:18 PM, Garrett Cooper wrote: > On Apr 10, 2012, at 7:53 PM, Wanlong Gao <gao...@cn...> wrote: > >> On 04/05/2012 10:10 AM, Garrett Cooper wrote: >> >>> On Wed, Apr 4, 2012 at 6:39 PM, Wanlong Gao <gao...@cn...> wrote: >>>> On 04/05/2012 08:42 AM, Garrett Cooper wrote: >>>> >>>>> Replace struct event_t with struct inotify_event >>>>> >>>>> Also do some minor whitespace cleanup while I'm >>>>> in the neighborhood. >>>> >>>> there's something wrong with this patch, please take a look at the ".name". >>> >>> Yeah... let me get back to you on that... >> >> >> Any update on this? > > I'm moving from CA to WA, but I'll try to get back to you sometime mid next week once I get settled in. That's great! I wonder what do CA and WA stand for? Thanks, Wanlong Gao > > Thanks! > -Garrett |
From: Cyril H. <ch...@su...> - 2012-05-03 13:48:58
|
Hi! > >>> > >>> Yeah... let me get back to you on that... > >> > >> > >> Any update on this? > > > > I'm moving from CA to WA, but I'll try to get back to you sometime mid next week once I get settled in. > > > That's great! I wonder what do CA and WA stand for? I would guess that these are city names or something like that... ;) And of course the patch is wrong, the event_t structure is used only to record what have you done for sake of comparing the sequence to the inotify events read later. -- Cyril Hrubis ch...@su... |
From: Garrett C. <yan...@gm...> - 2012-05-19 00:46:16
|
On May 3, 2012, at 5:46 AM, Cyril Hrubis wrote: > Hi! >>>>> >>>>> Yeah... let me get back to you on that... >>>> >>>> >>>> Any update on this? >>> >>> I'm moving from CA to WA, but I'll try to get back to you sometime mid next week once I get settled in. >> >> >> That's great! I wonder what do CA and WA stand for? > > I would guess that these are city names or something like that... ;) > > And of course the patch is wrong, the event_t structure is used only to > record what have you done for sake of comparing the sequence to the > inotify events read later. Yeah, I pulled that diff. |