From: <shu...@or...> - 2013-10-22 09:23:13
|
From: Shuang Qiu <shu...@or...> Testcase cgroup sometimes fail although there is no bug found. Initialize the exit status to fix it. Signed-off-by: Shuang Qiu <shu...@or...> --- .../controllers/cgroup/cgroup_regression_test.sh | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/testcases/kernel/controllers/cgroup/cgroup_regression_test.sh b/testcases/kernel/controllers/cgroup/cgroup_regression_test.sh index f5e0b4b..356c000 100755 --- a/testcases/kernel/controllers/cgroup/cgroup_regression_test.sh +++ b/testcases/kernel/controllers/cgroup/cgroup_regression_test.sh @@ -28,6 +28,8 @@ export TCID="cgroup_regression_test" export TST_TOTAL=10 export TST_COUNT=1 +failed=0 + tst_kvercmp 2 6 29 if [ $? -eq 0 ]; then tst_brkm TCONF ignored "test must be run with kernel 2.6.29 or newer" @@ -523,7 +525,7 @@ for ((cur = 1; cur <= $TST_TOTAL; cur++)) test_$cur } -rmdir cgroup/ +rmdir -p cgroup/* exit $failed -- 1.7.7 |
From: <ch...@su...> - 2013-10-23 14:41:44
|
Hi! > Testcase cgroup sometimes fail although there is no bug found. > Initialize the exit status to fix it. The patch looks fine, but the description lacks rationale for the rmdir change. -- Cyril Hrubis ch...@su... |
From: Shuang Q. <shu...@or...> - 2013-10-28 04:37:48
|
On 10/23/2013 10:41 PM, ch...@su... wrote: > Hi! >> Testcase cgroup sometimes fail although there is no bug found. >> Initialize the exit status to fix it. > The patch looks fine, but the description lacks rationale for the rmdir > change. > Thanks for review. Added more description. From: Shuang Qiu<shu...@or...> Testcase cgroup sometimes fail although there is no bug found. Initialize the exit status to fix it. Using "rmdir cgroup/" to clean up test_dir sometimes failed because there may be subdir not removed in cgroup/. Using "rmdir -p cgroup/*" instead. Signed-off-by: Shuang Qiu<shu...@or...> --- .../controllers/cgroup/cgroup_regression_test.sh | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/testcases/kernel/controllers/cgroup/cgroup_regression_test.sh b/testcases/kernel/controllers/cgroup/cgroup_regression_test.sh index f5e0b4b..356c000 100755 --- a/testcases/kernel/controllers/cgroup/cgroup_regression_test.sh +++ b/testcases/kernel/controllers/cgroup/cgroup_regression_test.sh @@ -28,6 +28,8 @@ export TCID="cgroup_regression_test" export TST_TOTAL=10 export TST_COUNT=1 +failed=0 + tst_kvercmp 2 6 29 if [ $? -eq 0 ]; then tst_brkm TCONF ignored "test must be run with kernel 2.6.29 or newer" @@ -523,7 +525,7 @@ for ((cur = 1; cur <= $TST_TOTAL; cur++)) test_$cur } -rmdir cgroup/ +rmdir -p cgroup/* exit $failed -- 1.7.7 |
From: Wanlong G. <gao...@cn...> - 2013-10-28 05:45:59
|
On 10/28/2013 12:37 PM, Shuang Qiu wrote: > Thanks for review. > Added more description. > > From: Shuang Qiu<shu...@or...> > > Testcase cgroup sometimes fail although there is no bug found. > Initialize the exit status to fix it. > Using "rmdir cgroup/" to clean up test_dir sometimes failed because there may be subdir not removed in cgroup/. > Using "rmdir -p cgroup/*" instead. > > Signed-off-by: Shuang Qiu<shu...@or...> Applied, thank you. Wanlong gao |