From: Li, J. <Ji...@wi...> - 2012-06-21 07:27:44
|
Hi, When I use runltp with the option [-b DEVICE], notice the typo as follows: sed -i "" -e "s|DEVICE_FS_TYPE|$DEVICE_FS_TYPE|" ${TMP}/alltests The runltp will hit error and exit. Is it a typo or I miss something else ? Thanks, Jin |
From: <ch...@su...> - 2012-06-21 12:23:57
|
Hi! > When I use runltp with the option [-b DEVICE], notice the typo as follows: > > sed -i "" -e "s|DEVICE_FS_TYPE|$DEVICE_FS_TYPE|" ${TMP}/alltests > > The runltp will hit error and exit. > > Is it a typo or I miss something else ? That line went in with Garrett's patch to improve the script. I guess he was using slightly different version of sed (or just typed the line wrong). (CCed him in case he remebers). And in any case we should fix that. Do you care to send a patch? -- Cyril Hrubis ch...@su... |
From: Wanlong G. <gao...@cn...> - 2012-06-22 02:35:43
|
Maybe a typo when replacing DEVICE_FS_TYPE. Signed-off-by: Wanlong Gao <gao...@cn...> --- runltp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/runltp b/runltp index 3bd5252..0d77a6e 100755 --- a/runltp +++ b/runltp @@ -683,7 +683,7 @@ main() sed -i "s|DEVICE|$DEVICE|" ${TMP}/alltests else echo "remove test cases which require the block device." - echo "You can specify it with option -b" + echo "You can specify it with option -b" sed -i "/DEVICE/d" ${TMP}/alltests fi @@ -719,7 +719,7 @@ main() fi if [ -n "$DEVICE" ]; then - sed -i "" -e "s|DEVICE_FS_TYPE|$DEVICE_FS_TYPE|" ${TMP}/alltests + sed -i "s|DEVICE_FS_TYPE|$DEVICE_FS_TYPE|" ${TMP}/alltests fi if [ $? -ne 0 ]; then -- 1.7.11.rc0 |
From: Wanlong G. <gao...@cn...> - 2012-06-26 08:27:00
|
On 06/22/2012 10:35 AM, Wanlong Gao wrote: > Maybe a typo when replacing DEVICE_FS_TYPE. Objections, Cooper? There isn't any other places have this odd statement in this file like here. Thanks, Wanlong Gao > > Signed-off-by: Wanlong Gao <gao...@cn...> > --- > runltp | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/runltp b/runltp > index 3bd5252..0d77a6e 100755 > --- a/runltp > +++ b/runltp > @@ -683,7 +683,7 @@ main() > sed -i "s|DEVICE|$DEVICE|" ${TMP}/alltests > else > echo "remove test cases which require the block device." > - echo "You can specify it with option -b" > + echo "You can specify it with option -b" > sed -i "/DEVICE/d" ${TMP}/alltests > fi > > @@ -719,7 +719,7 @@ main() > fi > > if [ -n "$DEVICE" ]; then > - sed -i "" -e "s|DEVICE_FS_TYPE|$DEVICE_FS_TYPE|" ${TMP}/alltests > + sed -i "s|DEVICE_FS_TYPE|$DEVICE_FS_TYPE|" ${TMP}/alltests > fi > > if [ $? -ne 0 ]; then > |
From: Garrett C. <yan...@gm...> - 2012-06-29 02:13:13
|
On Tue, Jun 26, 2012 at 1:26 AM, Wanlong Gao <gao...@cn...> wrote: > On 06/22/2012 10:35 AM, Wanlong Gao wrote: >> Maybe a typo when replacing DEVICE_FS_TYPE. > > Objections, Cooper? > There isn't any other places have this odd statement in this file > like here. LGTM. Reviewed-by: Garrett Cooper <yan...@gm...> |
From: Wanlong G. <gao...@cn...> - 2012-06-29 02:21:21
|
On 06/29/2012 10:13 AM, Garrett Cooper wrote: > On Tue, Jun 26, 2012 at 1:26 AM, Wanlong Gao <gao...@cn...> wrote: >> On 06/22/2012 10:35 AM, Wanlong Gao wrote: >>> Maybe a typo when replacing DEVICE_FS_TYPE. >> >> Objections, Cooper? >> There isn't any other places have this odd statement in this file >> like here. > > LGTM. > > Reviewed-by: Garrett Cooper <yan...@gm...> Thank you, pushed. Wanlong Gao > |
From: Garrett C. <yan...@gm...> - 2012-06-22 02:53:35
|
On Thu, Jun 21, 2012 at 12:27 AM, Li, Jin <Ji...@wi...> wrote: > Hi, > > When I use runltp with the option [-b DEVICE], notice the typo as follows: > > sed -i "" -e "s|DEVICE_FS_TYPE|$DEVICE_FS_TYPE|" ${TMP}/alltests > > The runltp will hit error and exit. > > Is it a typo or I miss something else ? It wasn't an intentional "typo". It's an inconsistency between BSD sed and GNU sed (something that irritates me from time to time). The above form works with BSD sed. Replacing `-i ""` with `-i '.bk'` should work. Thanks, -Garrett |