From: Peng H. <pe...@cn...> - 2011-02-24 10:08:50
|
Hi Garrett, There are two processes in cases, and the test need run from child process, so parent process should exit after invoking cleanup(). Signed-off-by: Peng Haitao <pe...@cn...> --- testcases/kernel/syscalls/waitpid/waitpid11.c | 1 + testcases/kernel/syscalls/waitpid/waitpid12.c | 1 + testcases/kernel/syscalls/waitpid/waitpid13.c | 1 + 3 files changed, 3 insertions(+), 0 deletions(-) diff --git a/testcases/kernel/syscalls/waitpid/waitpid11.c b/testcases/kernel/syscalls/waitpid/waitpid11.c index 1e631da..d61b624 100644 --- a/testcases/kernel/syscalls/waitpid/waitpid11.c +++ b/testcases/kernel/syscalls/waitpid/waitpid11.c @@ -112,6 +112,7 @@ int main(int ac, char **av) tst_resm(TPASS, "%s PASSED", TCID); } cleanup(); + tst_exit(); } else if (pid < 0) { tst_brkm(TBROK, cleanup, "fork failed"); } diff --git a/testcases/kernel/syscalls/waitpid/waitpid12.c b/testcases/kernel/syscalls/waitpid/waitpid12.c index 5c0ebe6..ac99c9a 100644 --- a/testcases/kernel/syscalls/waitpid/waitpid12.c +++ b/testcases/kernel/syscalls/waitpid/waitpid12.c @@ -113,6 +113,7 @@ int main(int argc, char **argv) tst_resm(TPASS, "%s PASSED", TCID); } cleanup(); + tst_exit(); } else if (pid < 0) { tst_brkm(TBROK, cleanup, "fork failed"); } diff --git a/testcases/kernel/syscalls/waitpid/waitpid13.c b/testcases/kernel/syscalls/waitpid/waitpid13.c index 8b908a9..7f7393e 100644 --- a/testcases/kernel/syscalls/waitpid/waitpid13.c +++ b/testcases/kernel/syscalls/waitpid/waitpid13.c @@ -110,6 +110,7 @@ int main(int ac, char **av) tst_resm(TPASS, "%s PASSED", TCID); } cleanup(); + tst_exit(); } else if (pid < 0) { tst_brkm(TBROK, cleanup, "fork failed"); } -- 1.7.1 -- Best Regards, Peng Haitao |
From: Garrett C. <yan...@gm...> - 2011-02-24 16:46:34
|
On Thu, Feb 24, 2011 at 2:08 AM, Peng Haitao <pe...@cn...> wrote: > Hi Garrett, > > There are two processes in cases, and the test need run from child process, > so parent process should exit after invoking cleanup(). Looks fine. I'll commit it tonight if no one else beats me to it. Thanks, -Garrett |
From: Peng H. <pe...@cn...> - 2011-02-28 01:06:06
|
Garrett Cooper said the following on 2011-2-25 0:46: >> There are two processes in cases, and the test need run from child process, >> so parent process should exit after invoking cleanup(). > > Looks fine. I'll commit it tonight if no one else beats me to it. > Thanks, Garrett, Would you commit the patch? Thanks, -- Best Regards, Peng Haitao |
From: Garrett C. <yan...@gm...> - 2011-03-04 10:13:52
|
On Sun, Feb 27, 2011 at 5:06 PM, Peng Haitao <pe...@cn...> wrote: > Garrett Cooper said the following on 2011-2-25 0:46: >>> There are two processes in cases, and the test need run from child process, >>> so parent process should exit after invoking cleanup(). >> >> Looks fine. I'll commit it tonight if no one else beats me to it. >> Thanks, > > Garrett, > > Would you commit the patch? I've committed a more extensive patch. Please test it out and let me know how it goes -- thanks! -Garrett |
From: Peng H. <pe...@cn...> - 2011-03-09 05:22:11
|
Hi Garrett, Garrett Cooper said the following on 2011-3-4 18:13: >> Would you commit the patch? > > I've committed a more extensive patch. Please test it out and let me > know how it goes -- thanks! The patch is OK, thanks for you work. Best Regards, Peng |
From: Caspar Z. <cz...@re...> - 2011-03-04 16:00:11
Attachments:
0001-syscalls-waitpid11-fix-compile-err.patch
|
On 03/04/2011 06:13 PM, Garrett Cooper wrote: > I've committed a more extensive patch. Please test it out and let me > know how it goes -- thanks! > -Garrett Hi Garrett, compile error occurs in this patch, here is a fix. -- Quality Engineer (Kernel) in Red Hat Software (Beijing) Co., R&D Branch http://www.cn.redhat.com/ TEL: +86-10-62608150 |
From: Garrett C. <yan...@gm...> - 2011-03-04 16:17:27
|
On Fri, Mar 4, 2011 at 7:59 AM, Caspar Zhang <cz...@re...> wrote: > On 03/04/2011 06:13 PM, Garrett Cooper wrote: >> I've committed a more extensive patch. Please test it out and let me >> know how it goes -- thanks! >> -Garrett > > Hi Garrett, compile error occurs in this patch, here is a fix. Sorry for the error -- thanks. -Garrett |