From: Jan S. <jst...@re...> - 2011-07-19 12:29:26
|
This patch fixes some failures caused by missing cleanup, leaving groups behind after some stress tests. Some stress tests failed to complete upon receiving SIGUSR1. 1. dmesg can rotate and number of found bugs can actually go down clear the buffer before test to avoid this 2. test_5: test should mount 2 subsystems, but mount command says "$subsys" instead of "$subsys2" 3. test_6: test may leave groups behind, fix rmdir to match test_6_1.sh 4. test_7_2: mounts whole cgroup not $subsys 5. test_10: can leave cgroups umounted before cleanup make sure cgroups are mounted before doing cleanup 6. test_*.sh scripts use trap in loop, which may cause bash to miss signal, see https://bugzilla.redhat.com/show_bug.cgi?id=695656 move trap outside loop to avoid it Signed-off-by: Jan Stancek <jst...@re...> --- .../controllers/cgroup/cgroup_regression_test.sh | 15 ++++++++++----- testcases/kernel/controllers/cgroup/test_10_1.sh | 3 +-- testcases/kernel/controllers/cgroup/test_10_2.sh | 3 +-- testcases/kernel/controllers/cgroup/test_3_1.sh | 3 +-- testcases/kernel/controllers/cgroup/test_3_2.sh | 3 +-- testcases/kernel/controllers/cgroup/test_6_1.sh | 3 +-- testcases/kernel/controllers/cgroup/test_9_1.sh | 3 +-- testcases/kernel/controllers/cgroup/test_9_2.sh | 3 +-- 8 files changed, 17 insertions(+), 19 deletions(-) |
From: Cyril H. <ch...@su...> - 2011-07-21 16:43:19
|
Hi! > This patch fixes some failures caused by missing cleanup, > leaving groups behind after some stress tests. > Some stress tests failed to complete upon receiving SIGUSR1. > > 1. dmesg can rotate and number of found bugs can actually go down > clear the buffer before test to avoid this > > 2. test_5: test should mount 2 subsystems, but mount command > says "$subsys" instead of "$subsys2" > > 3. test_6: test may leave groups behind, fix rmdir > to match test_6_1.sh > > 4. test_7_2: mounts whole cgroup not $subsys > > 5. test_10: can leave cgroups umounted before cleanup > make sure cgroups are mounted before doing cleanup > > 6. test_*.sh scripts use trap in loop, which may cause bash > to miss signal, see > https://bugzilla.redhat.com/show_bug.cgi?id=695656 > move trap outside loop to avoid it I know these are mostly trivial changes, but even that could you split them into several patches (they are easier to review, revert if needed...) -- Cyril Hrubis ch...@su... |