From: Andi K. <ak...@su...> - 2002-05-21 12:34:00
|
This fixes a FAIL on x86-64 and also makes it a bit more ISO-C compliant. In fact it was likely overwriting stack randomly on most architectures with 64bit time_t. -Andi Index: testcases/kernel/syscalls/fsync/fsync02.c =================================================================== RCS file: /cvsroot/ltp/ltp/testcases/kernel/syscalls/fsync/fsync02.c,v retrieving revision 1.1 diff -u -r1.1 fsync02.c --- testcases/kernel/syscalls/fsync/fsync02.c 27 Aug 2001 22:15:13 -0000 1.1 +++ testcases/kernel/syscalls/fsync/fsync02.c 21 May 2002 12:32:37 -0000 @@ -54,6 +54,7 @@ #include <sys/resource.h> #include <test.h> #include <usctest.h> +#include <time.h> #define BLOCKSIZE 8192 #define MAXBLKS 262144 @@ -82,7 +83,8 @@ long rlp; int ret, max_block; int i; - int time_start, time_end, time_delta; + time_t time_start, time_end; + double time_delta; int data_blocks; /* parse standard options */ @@ -124,10 +126,16 @@ } if (STD_FUNCTIONAL_TEST) { - if((time_delta = time_end - time_start) > TIME_LIMIT) { + if (time_end < time_start) { + tst_resm(TFAIL, "timer broken end %ld < start %ld", + time_end, time_start); + } + + + if((time_delta = difftime(time_end,time_start)) > TIME_LIMIT) { tst_resm(TFAIL, "fsync took too long: %d " "seconds; max_block: %d; data_blocks: " - "%d", time_delta, max_block, + "%d", (int)time_delta, max_block, data_blocks); } else { tst_resm(TPASS, "fsync() succeeded in an " |
From: Paul L. <pl...@au...> - 2002-05-21 13:01:46
|
Thanks for the fixes Andi, they have been commited. -Paul Larson |