From: Jonathan L. <la...@us...> - 2001-09-17 19:53:13
|
> I recall Jens did the same patch as you (just move the lock from global > to per-queue) last year, I have not seen Jens' previous patch, but based on your description, this patch is dissimilar. Except in __make_request, whenever the queue_lock is required to protect the queue, queue_lock is taken *in addition to* io_request_lock, rather than instead of io_request_lock. > you can find it on l-k, Manfred pointed out it > could have lock inversions with the different ide subchannels for > example. Other than those subtle deadlocks (that make it obviously not > suitable for production) I can't see much other problems. I assume those > subtle problems is what make Jens not happy about it. Thank you for examining the patch. I originally posted the patch to explore the feasibility and possible performance gains for server environments which would probably exclude IDE. I will look further into IDE correctness. Jonathan -- Jonathan Lahr IBM Linux Technology Center Beaverton, Oregon la...@us... 503-578-3385 |