Help save net neutrality! Learn more.
Close

#7 configure and lsdvd.c have wrong order of include

v1.0 (example)
closed
nobody
None
5
2014-09-25
2011-02-02
No

Hi

This regards lsdvd-0.16

You need to change the order on two #includes in your configure and lsdvd.c file in order for them to work properly.
as they are now they will give compilation errors

In configure:
when testing "dvdread/ifo_read.h" you do
---
#include <dvdread/ifo_read.h>
#include <stdint.h>
---
but it should be
---
#include <stdint.h>
#include <dvdread/ifo_read.h>
---

in lsdvd.c you do
---
#include <dvdread/ifo_read.h>
#include <string.h>
#include <sys/stat.h>
#include <stdio.h>
#include <stdlib.h>
#include <unistd.h>
#include <stdint.h>
#include "lsdvd.h"
---
but should be
---
#include <string.h>
#include <sys/stat.h>
#include <stdio.h>
#include <stdlib.h>
#include <unistd.h>
#include <stdint.h>
#include <dvdread/ifo_read.h>
#include "lsdvd.h"
---

/Stefan

Discussion

  • Steve Dibb

    Steve Dibb - 2014-09-25

    Fixed in git, thanks for the bug report!

     
  • Steve Dibb

    Steve Dibb - 2014-09-25
    • status: open --> closed
    • Group: --> v1.0 (example)
     

Log in to post a comment.