#20 losetup misses -P in getopt() call

[Mike Frysinger]

the patch to lomount.c does not add "P:" to the getopt() call which prevents `losetup -P` from working

[Jari Ruusu]

Logged In: YES
user_id=238645
Originator: NO

This embarrassing bug was fixed in loop-AES-v3.2b,
which was released on October 25 2007. ChangeLog entry:
"Fixed losetup -P cleartext key option which always
failed to work and printed error message saying so."

[Mike Frysinger]

Logged In: YES
user_id=114429
Originator: YES

we use the util-linux diffs and the last one there is:
util-linux-ng-2.13-1.diff.bz2 02-Sep-2007 08:55

can we get the diff updated as well please ?

[Jari Ruusu]

Logged In: YES
user_id=238645
Originator: NO

$ cd loop-AES-v3.2b
$ ls -l util-*
-rw-r--r-- 1 root root 142774 Oct 16 18:55 util-linux-2.12r.diff
-rw-r--r-- 1 root root 265681 Oct 23 18:57 util-linux-ng-2.13.0.1.diff

loop-AES-v3.2b tarball includes patches for latest
released versions of both util-linux and util-linux-ng.
The fix is in both patches.

[Mike Frysinger]

Logged In: YES
user_id=114429
Originator: YES

sorry, i was referring to this:
http://loop-aes.sourceforge.net/updates/

can we get that cleaned up or updated ?

[Jari Ruusu]

Logged In: YES
user_id=238645
Originator: NO

People complain when old versions are made unavailable.
Now, you seem to be unhappy about NOT making old
version unavailable.

It makes sense to make some version unavailable if it
has a bug so severe that it eats file systems or has
severe security flaw. This bug isn't such.

[Mike Frysinger]

Logged In: YES
user_id=114429
Originator: YES

you already provide old versions of the patch in the loop-aes tarball. keeping a known buggy version in a folder called "updates" is simply misleading. when you make updates to the loop-aes tarball, you should update the split out util-linux patch as well, or dont provide the util-linux split patch.