loki-lib-cvs

[Loki-lib-cvs] SF.net SVN: loki-lib:[906] trunk/test/SmartPtr/colvin_gibbons_trick.cpp

[<ric...@us...>]

Revision: 906
          http://loki-lib.svn.sourceforge.net/loki-lib/?rev=906&view=rev
Author:   rich_sposato
Date:     2008-11-12 07:00:16 +0000 (Wed, 12 Nov 2008)

Log Message:
-----------
Adding test case for bug 2080889.

Added Paths:
-----------
    trunk/test/SmartPtr/colvin_gibbons_trick.cpp

Added: trunk/test/SmartPtr/colvin_gibbons_trick.cpp
===================================================================
--- trunk/test/SmartPtr/colvin_gibbons_trick.cpp	                        (rev 0)
+++ trunk/test/SmartPtr/colvin_gibbons_trick.cpp	2008-11-12 07:00:16 UTC (rev 906)
@@ -0,0 +1,121 @@
+////////////////////////////////////////////////////////////////////////////////
+// Test program for The Loki Library
+// Copyright (c) 2008 Richard Sposato
+// Permission to use, copy, modify, distribute and sell this software for any
+//     purpose is hereby granted without fee, provided that the above copyright
+//     notice appear in all copies and that both that copyright notice and this
+//     permission notice appear in supporting documentation.
+// The authors make no representations about the
+//     suitability of this software for any purpose. It is provided "as is"
+//     without express or implied warranty.
+////////////////////////////////////////////////////////////////////////////////
+
+// $Id$
+
+
+// ----------------------------------------------------------------------------
+
+
+// loki_smart_auto_ptr.cpp Test program for Loki::SmartPtr configured as
+// auto_ptr using Colvin-Gibbons trick
+
+#ifdef HAVE_CONFIG_H
+#include <config.h>
+#endif
+
+#include <loki/SmartPtr.h>
+
+#include <memory>
+#include <iostream>
+#include <cstdlib>
+
+
+using namespace Loki;
+using namespace std;
+
+
+// ----------------------------------------------------------------------------
+
+class Base
+{
+public:
+    virtual ~Base() {}
+
+    virtual void Hello() { cout << "Base Hello, world!" << endl; }
+};
+
+// ----------------------------------------------------------------------------
+
+class Derived: public Base
+{
+public:
+    virtual void Hello() { cout << "Derived Hello, world!" << endl; }
+};
+
+
+// ----------------------------------------------------------------------------
+
+typedef auto_ptr< Base > AutoPtrBase;
+typedef auto_ptr< Derived > AutoPtrDerived;
+
+typedef SmartPtr< Base, DestructiveCopy > SmartAutoPtrBase;
+typedef SmartPtr< Derived, DestructiveCopy > SmartAutoPtrDerived;
+
+
+// ----------------------------------------------------------------------------
+
+template <class TPtrBase>
+TPtrBase CreateBase()
+{
+    return TPtrBase( new Base );
+}
+
+// ----------------------------------------------------------------------------
+
+template <class TPtrDerived>
+TPtrDerived CreateDerived()
+{
+    return TPtrDerived( new Derived );
+}
+
+// ----------------------------------------------------------------------------
+
+template < class TPtrBase >
+void UseBase( TPtrBase ptr )
+{
+    ptr->Hello();
+}
+
+// ----------------------------------------------------------------------------
+
+template < class TPtrBase, class TPtrDerived >
+void DoTest()
+{
+    TPtrBase spb0 = CreateBase< TPtrBase >();
+    TPtrBase spb1( spb0 );
+
+    UseBase< TPtrBase >( CreateBase< TPtrBase >() );
+
+    TPtrDerived spd1 = CreateDerived< TPtrDerived >();
+    TPtrBase spb2( spd1 );
+
+    // NOTE: this does not compile with gcc 4.3.1 also for std::auto_ptr;
+    // it should work (Copy-initialization, base-from-derived)
+    // according to http://www.open-std.org/jtc1/sc22/wg21/docs/papers/1997/N1128.pdf
+    // It does compile with Visual C++ 8 (need to test with 9)
+    // UseBase<TPtrBase>(CreateDerived<TPtrDerived>());
+
+    // Quick fix
+    UseBase< TPtrBase >( TPtrBase( CreateDerived< TPtrDerived >() ) );
+}
+
+// ----------------------------------------------------------------------------
+
+void TryColvinGibbonsTrick( void )
+{
+    DoTest<AutoPtrBase, AutoPtrDerived>(); // OK
+    DoTest<SmartAutoPtrBase, SmartAutoPtrDerived>(); // FIXME: eror:
+    // assignment of read-only reference 'val'
+}
+
+// ----------------------------------------------------------------------------


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Loki-lib-cvs] SF.net SVN: loki-lib:[1103] trunk/test/SmartPtr/colvin_gibbons_trick.cpp

[<ric...@us...>]

Revision: 1103
          http://loki-lib.svn.sourceforge.net/loki-lib/?rev=1103&view=rev
Author:   rich_sposato
Date:     2011-09-17 02:25:43 +0000 (Sat, 17 Sep 2011)
Log Message:
-----------
Removed #if 0 lines because compiler choked on it.

Modified Paths:
--------------
    trunk/test/SmartPtr/colvin_gibbons_trick.cpp

Modified: trunk/test/SmartPtr/colvin_gibbons_trick.cpp
===================================================================
--- trunk/test/SmartPtr/colvin_gibbons_trick.cpp	2011-09-17 02:20:19 UTC (rev 1102)
+++ trunk/test/SmartPtr/colvin_gibbons_trick.cpp	2011-09-17 02:25:43 UTC (rev 1103)
@@ -120,48 +120,3 @@
 
 // ----------------------------------------------------------------------------
 
-
-#if 0
-
-https://sourceforge.net/tracker/index.php?func=detail&aid=2080889&group_id=29557&atid=396644
-
-To fix the compile bug we have to disable the (const T&) ctor and use RefToValue,
-the way how it is done in  auto_prt.
-
-But I'm not sure about the consequences of such a change.
-
-Index: loki/SmartPtr.h
-===================================================================
---- loki/SmartPtr.h	(revision 910)
-+++ loki/SmartPtr.h	(working copy)
-@@ -1175,6 +1175,7 @@
-             GetImplRef(*this) = OP::Clone(GetImplRef(rhs));
-         }
- 
-+        /*
-         template
-         <
-             typename T1,
-@@ -1187,6 +1188,7 @@
-         SmartPtr(const SmartPtr<T1, OP1, CP1, KP1, SP1, CNP1 >& rhs)
-         : SP(rhs), OP(rhs), KP(rhs), CP(rhs)
-         { GetImplRef(*this) = OP::Clone(GetImplRef(rhs)); }
-+		*/
- 
-         template
-         <
-@@ -1205,7 +1207,10 @@
- 
-         SmartPtr(RefToValue<SmartPtr> rhs)
-         : SP(rhs), OP(rhs), KP(rhs), CP(rhs)
--        {}
-+        {
-+            SmartPtr& ref = rhs;
-+            GetImplRef(*this) = OP::Clone(GetImplRef(ref)); 
-+        }
- 
-         operator RefToValue<SmartPtr>()
-         { return RefToValue<SmartPtr>(*this); }
-
-#endif
-

This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.