#98 Make dnf5 less verbose if it is not installed

[Andrew Myers]

If dnf5 is not installed on the system it is unnecessarily verbose.

[Frank Crawford]

I half agree, the last 2 lines can be moved, although they also need to be surounded by a Debug level.

However, the path to dnf5 is important if it fails to find dnf5, and so should not be after that test.

However, and additional point is all these lines should not be seen unless you have debugging enabled, so what are you looking for?

[Andrew Myers]

I have debug set to 5 so that I can see all the tests that have been carried out.

I am not sure that I see your point about the pat the dnf5. If the script fails to find dnf5, and it is installed, then the path set by the script must be wrong, so quoting it will be no help. The script would need to be changed so that the correct path is found from the beginning.

Surely the same point would apply to several other scripts?

[Frank Crawford]

Your point on listing the value before the test is exactly why it is in that order. If it is set to a value and it is wrong, having it listed prior that test may help with the troubleshooting. In addition, if it is not actually set then tat will give you a different area to troubleshoot.

[Andrew Myers]

I see your point. Could we change the one line output to:
print STDERR "\n\nDEBUG: Exiting DNF5 Filter - dnf not found at $pathto_dnf5\n\n";
which is consistent with, for example, xntpd?

[Frank Crawford]

That sounds reasonable. I'll do an update something like that sometime this week.

[Andrew Myers]

Thank you