Small bug in fail2ban-script

[Thomas Wilhelmi]

Hi,

I don't know if this is already known but it seems to be present also in the newest version. These lines (starting at line 207):

~~~
if (keys(%NoticeList) && $Detail>7) {
print "\nNotices:\n";
foreach my $line (sort {$a cmp $b} keys %OtherList) {
print " $line: $OtherList{$line} Time(s)\n";
}
}
~~~

should be:

if (keys(%NoticeList) && $Detail>7) {
print "\nNotices:\n";
foreach my $line (sort {$a cmp $b} keys %NoticeList) {
print " $line: $NoticeList{$line} Time(s)\n";
}
}

Best regards

[Bjorn]

Thanks for reporting this; it had fallen off my radar. Fixed in repository.

[Alexandre Vroublevski]

Hi,

after upgrading logwatch from v7.4.3 -> v7.7 I noticed, that the fail2ban report was missing host names, resolved from their ip-addresses.

And I found, for example, in sshd service script the call of DoLookup() (from line 33):

my $IllegalUsersThreshold = $ENV{'illegal_users_threshold'} || 0;
DoLookup( $ENV{'sshd_ip_lookup'} );
my $DebugCounter = 0;

Then, I added the line to the fail2ban service script:
was (from line 47):

my %ServicesIgnored = ();

#Init String Containers

became:

my %ServicesIgnored = ();
DoLookup (1);

#Init String Containers

And voila - the host names appeared in the report.
I've checked, there are no changes in the scripts of version 7.10.

Best regards