feat(connector): add dingtalk connector
Identity infrastructure for developers, Auth0 open source alternative
Brought to you by:
fleuraly
Originally created by: anyidea
Originally owned by: anyidea
Added support for DingTalk as a login provider in the Logto repository. This includes the necessary configurations and authentication flow to enable users to log in using their DingTalk accounts.
.changeset I'm a beginner front-end developer, transitioning from a back-end role. I appreciate any feedback or corrections to improve this contribution. Thank you for your understanding and support!
Originally posted by: github-actions[bot]
COMPARE TO
masterTotal Size Diff ⚠️ 📈 +19.19 KB
Diff by File
|Name|Diff| |---|---| |packages/connectors/connector-dingtalk-web/README.md|:chart_with_upwards_trend: +1.86 KB| |packages/connectors/connector-dingtalk-web/logo.svg|:chart_with_upwards_trend: +1.12 KB| |packages/connectors/connector-dingtalk-web/package.json|:chart_with_upwards_trend: +2.08 KB| |packages/connectors/connector-dingtalk-web/src/constant.ts|:chart_with_upwards_trend: +1.88 KB| |packages/connectors/connector-dingtalk-web/src/index.test.ts|:chart_with_upwards_trend: +4.45 KB| |packages/connectors/connector-dingtalk-web/src/index.ts|:chart_with_upwards_trend: +4.34 KB| |packages/connectors/connector-dingtalk-web/src/mock.ts|:chart_with_upwards_trend: +115 Bytes| |packages/connectors/connector-dingtalk-web/src/types.ts|:chart_with_upwards_trend: +1.09 KB| |pnpm-lock.yaml|:chart_with_upwards_trend: +2.25 KB|Originally posted by: anyidea
This PR resolves [#1800]
Originally posted by: anyidea
Originally posted by: darcyYe
Thanks for your contribution @anyidea , I left some comments. Overall there is nothing wrong but there are some implementation details that need some comments to help reviewers and maintainers more easily understand your code. A simple judgment is that if this is something that when you were implementing it, you were not sure whether it needs a comment, it is better to just add it.
Originally posted by: anyidea
Thank for the feedback! I appreciate your time in reviewing my PR. I will go through your comments and add the necessary explanations to make the code more understandable. I’ll update the PR soon.