Menu

#5886 feat(connector): postmark email connector

open
nobody
2024-05-17
2024-05-16
Anonymous
No

Originally created by: srs
Originally owned by: srs

Summary

Implemented a Postmark email connector that uses Postmark API rather than SMTP. This provides the ability to use templates stored in Postmark instead of the templates stored in JSON.

This is implemented by looking at connector-sendgrid-email and implemented it as my understanding of best practices and convensions.

Testing

Have a simple uint-test that only checks configuration is valid (as also connector-sendgrid-email has). Else I did manual testing by connecting it in Logto UI and sending a test email trough the UI. Have also tested it in real-world scenarios by connecting it to an email provider.

Checklist

  • .changeset
  • unit tests
  • integration tests
  • necessary TSDoc comments

Discussion

  • Anonymous

    Anonymous - 2024-05-16

    Originally posted by: github-actions[bot]

    COMPARE TO master

    Total Size Diff ⚠️ 📈 +12.37 KB

    Diff by File |Name|Diff| |---|---| |packages/connectors/connector-postmark/CHANGELOG.md|:chart_with_upwards_trend: +84 Bytes| |packages/connectors/connector-postmark/README.md|:chart_with_upwards_trend: +1.98 KB| |packages/connectors/connector-postmark/logo.svg|:chart_with_upwards_trend: +3.63 KB| |packages/connectors/connector-postmark/package.json|:chart_with_upwards_trend: +2.03 KB| |packages/connectors/connector-postmark/src/constant.ts|:chart_with_upwards_trend: +1.34 KB| |packages/connectors/connector-postmark/src/index.test.ts|:chart_with_upwards_trend: +345 Bytes| |packages/connectors/connector-postmark/src/index.ts|:chart_with_upwards_trend: +1.67 KB| |packages/connectors/connector-postmark/src/mock.ts|:chart_with_upwards_trend: +320 Bytes| |packages/connectors/connector-postmark/src/types.ts|:chart_with_upwards_trend: +1002 Bytes|
     
  • Anonymous

    Anonymous - 2024-05-16
    • assigned_to: srs
     
  • Anonymous

    Anonymous - 2024-05-16

    Originally posted by: srs

    This solves [#5885].

     

    Related

    Tickets: #5885

  • Anonymous

    Anonymous - 2024-05-17

    Originally posted by: simeng-li

    @wangsijie @darcyYe can you guys take a look thx.

     
  • Anonymous

    Anonymous - 2024-05-17

    Originally posted by: wangsijie

    Also, it would be nice if you can make the commits signed.

     
  • Anonymous

    Anonymous - 2024-05-17

    Originally posted by: srs

    I will add some basic tests and do signed commits.

     

Log in to post a comment.

MongoDB Logo MongoDB