Menu

#5843 chore(toolkit): update mobileUriSchemeProtocolRegEx

open
nobody
2024-05-21
2024-05-10
Anonymous
No

Originally created by: ImSingee
Originally owned by: ImSingee

Summary

There's no requirement that the mobile schema must be xxx.my://; a simple myapp:// should be okay.

Testing

Before:

image

After:
image

Checklist

  • .changeset
  • unit tests
  • integration tests
  • necessary TSDoc comments

Discussion

  • Anonymous

    Anonymous - 2024-05-10

    Originally posted by: github-actions[bot]

    COMPARE TO master

    Total Size Diff 📉 -27 Bytes

    Diff by File |Name|Diff| |---|---| |packages/toolkit/core-kit/src/regex.ts|:chart_with_downwards_trend: -12 Bytes| |packages/toolkit/core-kit/src/utils/url.test.ts|:chart_with_downwards_trend: -15 Bytes|
     
  • Anonymous

    Anonymous - 2024-05-10
     
  • Anonymous

    Anonymous - 2024-05-16

    Originally posted by: ImSingee

    @charIeszhao Sadly to see that. I really can't understand the reason that URL scheme of the native app must be xx.xx://. There are tons of apps that have a single xx:// URL scheme.

     
  • Anonymous

    Anonymous - 2024-05-16

    Originally posted by: charIeszhao

    @charIeszhao Sadly to see that. I really can't understand the reason that URL scheme of the native app must be xx.xx://. There are tons of apps that have a single xx:// URL scheme.

    Well, I understand that in real life there are many apps that do not have a domain based scheme, however, it is clearly stated in the IETF standard that these schemes should not be used.

    Here's the documentation for your reference: https://datatracker.ietf.org/doc/html/draft-ietf-oauth-native-apps-06#section-7.1.1

     
  • Anonymous

    Anonymous - 2024-05-21

    Originally posted by: ImSingee

    @charIeszhao Another similar problem: I'm developing an app with Expo, which supports both React Native and React Web. But I can't configure the https scheme to the native app, and I can't configure the xx.xx schema to the web app. So, it seems there's no way to use a single appId for both platforms. Is it possible to support apps like this in Logto?

     

Log in to post a comment.

MongoDB Logo MongoDB