Hi,
I am very happy to find your project. I am connected to a big project
where the main business logic is implemented in plsql.
Unfortunately, I am not capable to understand the useful part of code
without working, because you know old system with a couple years after
some change requests and some people changes, I just based only on the
working code to filter the nonworking and unnecessary parts.
So, I think your product would be the proper component to make logging.
I analysed your code, and I have a question:
I think, the performance of a logger is critical, because this can
decrease the processing speed. So as I am using the log4j, I want to
use the isLevelEnabled to minimize the overhead.
I think this method could contain only an IF. This would be the
maximum extra processing time.
Although I see:
isLevelEnabled:
- getDefaultContext (expensive)
- calleurname (expensive)
- init (cheap)
- getLevel (cheap)
- IF
So you can see, before the IF there are extra overhead. Why?
I think, we need to make default context only once, when the session is started.
However, we can solve to manage separately the section or calculate
this on demand.
So sum up, I would be happy if the isLevelEnabled method is primitive
step, so it just contains a simple IF.
What do you think?
Thanks!
--
Andor
|
