Re: [log4perl-devel] Inconsistency with appender_thresholds_adjust()

[Mike S. <m...@pe...>]

On Wed, 12 Dec 2007 Oli...@Li... wrote:

> I'm trying to implement a framwork for my perl scripts using your
> excellent library log4perl and I'm really happy with it.

Great, thanks for the kind words!

> I have just a short question, to the function
> appender_thresholds_adjust().  I found, that a threshold offset of
> 0 has the same effect as a threshold offset of -1.  This seems to be
> an inconcistency for me. I would expect, that an offset of 0 leaves
> the threshold unchanged.

Hmm, that's a bug. I've checked in a fix for Log::Log4perl
1.15 to let appender_thresholds_adjust() return right away if the
'delta' is set to 0. Until 1.15 goes out to CPAN (might be a month
or so), please check for the "==0" case explicitly and suppress the
call to appender_thresholds_adjust().

Thanks for letting us know!

-- Mike

Mike Schilli
m...@pe...

>
> This makes sense, when I want to make some arithmetic with the log level:
> Standard log level = WARN ($StandardLogLevel = 1;)
> command line: --verbosity=x ($Verbosity = x;)
> Levels: Errors:   x=0
>         Warnings: x=1
>         Info:     x=2
>         Debug:    x=3
>         All:      x=4
> Perl: Log::Log4perl->appender_thresholds_adjust($StandardLogLevel -
> $Verbosity);
>
> Or is there any special reason, why the function was implemented that way?
>
> Regards,
>
> Oliver
>
>
> -------------------------------------------------------------------------
> SF.Net email is sponsored by:
> Check out the new SourceForge.net Marketplace.
> It's the best place to buy or sell services for
> just about anything Open Source.
> http://sourceforge.net/services/buy/index.php
> _______________________________________________
> log4perl-devel mailing list
> log...@li...
> https://lists.sourceforge.net/lists/listinfo/log4perl-devel
>