[log4perl-devel] Re: DBI test cases show errors

[Kevin G. <ke...@go...>]

 >> looks like something's not ok with the DBI test cases ... t/034DBI.t
 >> shows a bunch of errors. Any file not yet checked in perhaps?
 >
 > I see, SQL::Statement seems to have been changed significantly recently,
 > if you don't run 1.00x (like I did), the tests fail. I changed 034DBI.t
 > to ask for 1.005.


Actually, I think it was DBD::CSV, I made some changes to 034DBI.t 
testing them against a more recent DBD::CSV, the changes break under the 
older versions.  I've fixed the test script to work under both old and 
new expectations, and checked it in, fixes are shown below.


      eval {
          require DBD::CSV;
          require SQL::Statement;
-        die "" if $SQL::Statement::VERSION < 1.005;
+        #die "" if $SQL::Statement::VERSION < 1.005;
      };
      if ($@) {
          print STDERR "DBD::CSV or SQL::Statement 1.005 not installed, 
skipping tests\n";
@@ -112,6 +112,8 @@
  EOL
    $got =~ s/[^\w ,"()]//g;  #silly DBD_CSV uses funny EOL chars
    $expected =~ s/[^\w ,"()]//g;
+  $got = lc $got;  #accounting for variations in DBD::CSV behavior
+  $expected = lc $expected;
    ok($got, $expected);
  }

@@ -132,6 +134,8 @@
    $expected =~ s/[^\w ,"()]//g;
    $got =~ s/HASH\(.+?\)//;
    $expected =~ s/HASH\(.+?\)//;
+  $got = lc $got;  #accounting for variations in DBD::CSV behavior
+  $expected = lc $expected;
    ok($got, $expected);
  }

@@ -174,12 +178,12 @@
  $stmt = <<EOL;
      CREATE TABLE log4perltest (
        loglevel     char(9) ,
-      message   char(128),
+      message   char(128)

    )
  EOL

-$dbh->do($stmt);
+$dbh->do($stmt) || die "do failed on $stmt".$dbh->errstr;


  $config = <<'EOT';
@@ -220,6 +224,8 @@
  EOL
    $got =~ s/[^\w ,"()]//g;  #silly DBD_CSV uses funny EOL chars
    $expected =~ s/[^\w ,"()]//g;
+  $got = lc $got;  #accounting for variations in DBD::CSV behavior
+  $expected = lc $expected;
    ok($got, $expected);
  }

> 
> -- 
> -- Mike
> Mike Schilli
> m...@pe...

-- 
Happy Trails . . .

Kevin M. Goess
(and Anne and Frank)
904 Carmel Ave.
Albany, CA  94706
(510) 525-5217