[log4perl-devel] Re: patch against 0.34 to build with 5.8.1 pre

[Mike S. <m...@pe...>]

On Thu, 19 Jun 2003, Jim Cromie wrote:

> attached (and included below) is a patch to fix
>     1    a syntax error in Level,
>     2    a NOT-READY one against t/032RollingFile.t

Thanks, I've applied your first patch. The 'my' fix for the 032 test case
was already checked into CVS.

The real problem with Log::Dispatch::FileRotate is pretty severe, though:
Looks like the latest Log::Dispatch::FileRotate (1.09) expects its 'size'
parameter now in megabytes, not bytes.

I've changed both JavaMap/RollingFileAppender.pm and the test case, here's
the diff between the last release and now:

Index: lib/Log/Log4perl/JavaMap/RollingFileAppender.pm
===================================================================
RCS file: /cvsroot/log4perl/Log-Log4perl/lib/Log/Log4perl/JavaMap/RollingFileAppender.pm,v
retrieving revision 1.2
retrieving revision 1.3
diff -a -u -r1.2 -r1.3
--- lib/Log/Log4perl/JavaMap/RollingFileAppender.pm	18 Nov 2002 20:04:28 -0000	1.2
+++ lib/Log/Log4perl/JavaMap/RollingFileAppender.pm	20 Jun 2003 07:46:35 -0000	1.3
@@ -57,10 +57,9 @@
     }elsif (defined $data->{size}{value}){
         $size = $data->{size}{value};
     }else{
-        $size = 10_000_000;
+        $size = 10;
     }

-
     return Log::Log4perl::Appender->new("Log::Dispatch::FileRotate",
         name      => $appender_name,
         filename  => $filename,
@@ -90,7 +89,7 @@
     File
     Append      "true|false|1|0" default=true
     BufferedIO  "true|false|1|0" default=false (i.e. autoflush is on)
-    MaxFileSize default 10_000_000
+    MaxFileSize default=10 (in MB)
     MaxBackupIndex default is 1

 Possible config properties for Log::Dispatch::FileRotate are
Index: t/032JRollFile.t
===================================================================
RCS file: /cvsroot/log4perl/Log-Log4perl/t/032JRollFile.t,v
retrieving revision 1.3
retrieving revision 1.6
diff -a -u -r1.3 -r1.6
--- t/032JRollFile.t	31 May 2003 18:51:29 -0000	1.3
+++ t/032JRollFile.t	20 Jun 2003 07:36:29 -0000	1.6
@@ -21,7 +21,6 @@
     mkdir("$WORK_DIR", 0755) || die "can't create $WORK_DIR ($!)";
 }

-my $WORK_DIR = File::Spec->catfile(qw(t tmp));
 use vars qw(@outfiles); @outfiles = (File::Spec->catfile($WORK_DIR, 'rolltest.log'),
                                      File::Spec->catfile($WORK_DIR, 'rolltest.log.1'),
                                      File::Spec->catfile($WORK_DIR, 'rolltest.log.2'),);
@@ -30,14 +29,13 @@
     unlink $f if (-e $f);
 }

-
 my $conf = <<CONF;
 log4j.category.cat1      = INFO, myAppender

 log4j.appender.myAppender=org.apache.log4j.RollingFileAppender
 log4j.appender.myAppender.File=@{[File::Spec->catfile($WORK_DIR, 'rolltest.log')]}
 #this will roll the file after one write
-log4j.appender.myAppender.MaxFileSize=15
+log4j.appender.myAppender.MaxFileSize=@{[1/1024]}
 log4j.appender.myAppender.MaxBackupIndex=2
 log4j.appender.myAppender.layout=org.apache.log4j.PatternLayout
 log4j.appender.myAppender.layout.ConversionPattern=%-5p %c - %m%n
@@ -48,17 +46,17 @@

 my $logger = Log::Log4perl->get_logger('cat1');

-$logger->debug("debugging message 1 ");
-$logger->info("info message 1 ");
-$logger->warn("warning message 1 ");
-$logger->fatal("fatal message 1 ");
-
+$logger->debug("x" x 1024 . "debugging message 1 ");
+$logger->info("x" x 1024  . "info message 1 ");
+$logger->warn("x" x 1024  . "warning message 1 ");
+$logger->fatal("x" x 1024 . "fatal message 1 ");

+my $rollfile = File::Spec->catfile($WORK_DIR, 'rolltest.log.2');

-open (F, File::Spec->catfile($WORK_DIR, 'rolltest.log.2'));
+open F, $rollfile or die "Cannot open $rollfile";
 my $result = <F>;
 close F;
-like($result, qr/^INFO  cat1 - info message 1/);
+like($result, qr/^INFO  cat1 - x+info message 1/);

 #MaxBackupIndex is 2, so this file shouldn't exist
 ok(! -e File::Spec->catfile($WORK_DIR, 'rolltest.log.3'));
@@ -66,4 +64,3 @@
 foreach my $f (@outfiles){
     unlink $f if (-e $f);
 }
-

-- Mike

Mike Schilli
m...@pe...
http://perlmeister.com